Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for SQLAlchemy 1.4 #177

Merged
merged 228 commits into from May 21, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
228 commits
Select commit Hold shift + click to select a range
0fc64fa
Fixed a dependency problem that caysed test failures in Python 3.6.
jimfulton Apr 12, 2021
bfdda68
Started implementing SqlAlchemy dialect-compliance tests
jimfulton Apr 15, 2021
41cb2dd
Handle parameters in in
jimfulton Apr 15, 2021
631c060
fixed regex to allow multi-character parameter names.
jimfulton Apr 15, 2021
aa85cb9
Fixed rendering of string literals.
jimfulton Apr 16, 2021
c7da257
Provide default values for primary keys and other fixes...
jimfulton Apr 16, 2021
3916239
Narrowed skips and license comment diagnosed reasons for skipped fail…
jimfulton Apr 16, 2021
46b30b4
use Google license
jimfulton Apr 16, 2021
36a0033
Fixed like (% and _) escapes.
jimfulton Apr 19, 2021
d079fbe
Handle BIGNUMERIC
jimfulton Apr 19, 2021
7e60691
Skip tests that want to stpre floats as numeric.
jimfulton Apr 19, 2021
4a1bafd
skip tests for offsets without limits. BigQuery doesn't allow that.
jimfulton Apr 19, 2021
e07b1f0
BIGNUMERIC lets us handle many significant digits.test_many_significa…
jimfulton Apr 19, 2021
656af06
Skip LongNameBlowoutTest because it requires features (indexes, prima…
jimfulton Apr 19, 2021
a085db6
We have to rewrite these tests, because of forcing use_labels=True
jimfulton Apr 19, 2021
681ea47
BigQuery returns deleted and updated rows, which SQLAlchemy doesn't e…
jimfulton Apr 19, 2021
cde5bf8
Fixed a dependency problem that caysed test failures in Python 3.6.
jimfulton Apr 12, 2021
76cf078
Provide a bigquery mock based on sqlite
jimfulton Apr 20, 2021
ee46a1e
Don't force labels in select.
jimfulton Apr 20, 2021
62432a3
merge riversnake-fix-78
jimfulton Apr 20, 2021
a54b946
No need to work around forced labels anymore.
jimfulton Apr 22, 2021
1320f32
Updated sqlite-bases mock
jimfulton Apr 22, 2021
4f098fd
Added test that types are injected into parameter placeholders.
jimfulton Apr 22, 2021
2c76342
Oops, need to call super even when there are where clauses.
jimfulton Apr 22, 2021
68f9043
When SQLAlchemy thinks it knows a parameter type, include it in the p…
jimfulton Apr 23, 2021
be1e215
Don't skip some numeric tests and skip some CTE tests
jimfulton Apr 23, 2021
39f1955
Can't coerce datetime to date.
jimfulton Apr 23, 2021
9e266f2
reenable some tests now that we pass type infor to bigquery
jimfulton Apr 23, 2021
fa84c95
Enable error on warnings -- a test depends on it.
jimfulton Apr 24, 2021
b01d2ce
Added table and column comment support.
jimfulton Apr 24, 2021
dc91449
get_schema_names should return all of the schema names.
jimfulton Apr 24, 2021
3743abe
Retrieval of view definitions.
jimfulton Apr 24, 2021
dcc7e45
handle dateish literals.
jimfulton Apr 24, 2021
163d031
BigQuery doesn't want schema names in column names.
jimfulton Apr 24, 2021
c47a83d
Allow mutating table descriptions/comments.
jimfulton Apr 24, 2021
9444c20
skip tests that depend on BigQuery keeping track of column details.
jimfulton Apr 24, 2021
30c8ed7
Handle TIMESTAMP literals.
jimfulton Apr 24, 2021
0ef4909
Fixed some broken TIMESTAMP tests.
jimfulton Apr 24, 2021
99629cf
enabled more tests.
jimfulton Apr 24, 2021
5e6e48d
remove extra lines.
jimfulton Apr 26, 2021
83feb1e
blacken
jimfulton Apr 26, 2021
896a082
added missing test for api.py
jimfulton Apr 26, 2021
497cc90
Ignore flake8 complaint about * import.
jimfulton Apr 26, 2021
7e5399a
lint and minor cleanup
jimfulton Apr 26, 2021
e48dd58
Removed unused variable.
jimfulton Apr 26, 2021
395a2d4
Get to 100% coverage in test_parse_url
jimfulton Apr 26, 2021
07af7ef
Don't need because we can't test temp tables
jimfulton Apr 27, 2021
ea99108
requirements.py -- It's used by compliance testing.
jimfulton Apr 27, 2021
7039f05
Added Binary literal handling, and ...
jimfulton Apr 27, 2021
0f2d315
Updated fauxdb to correct for some sqlite differences.
jimfulton Apr 27, 2021
9db1e3b
Fixed santy check
jimfulton Apr 27, 2021
50e3448
blackened
jimfulton Apr 27, 2021
f449c5e
Added a test that exercises type handling for all the types.
jimfulton Apr 27, 2021
d000075
Added table reference tests
jimfulton Apr 28, 2021
190136e
test get_view_definition
jimfulton Apr 28, 2021
acdd4d2
removed a private function that's never called.
jimfulton Apr 28, 2021
3e73a0a
table and view list tests
jimfulton Apr 28, 2021
4c6d72d
Moar unit tests and coverage
jimfulton Apr 29, 2021
349269f
use latest bg release, because we depend on changes there.
jimfulton Apr 29, 2021
717dd77
removed breakpoint that shouldn't have been checked in.
jimfulton Apr 29, 2021
7ba7813
Bypass google authentication.
jimfulton Apr 30, 2021
c22565e
Test JSON deserialization.
jimfulton Apr 30, 2021
dc246ae
Test getting project id from authentication.
jimfulton Apr 30, 2021
b914ee3
removed some unneeded code.
jimfulton Apr 30, 2021
a7e49e9
Simplify string and binary literal processors to not expect None.
jimfulton Apr 30, 2021
53883d5
Tested comment support
jimfulton Apr 30, 2021
5b1e77e
Cleaned up comment handling.
jimfulton Apr 30, 2021
beaf0b6
generalized options handling.
jimfulton Apr 30, 2021
8236d5b
test dialect-options handling.
jimfulton Apr 30, 2021
8e41b4d
constraints are ignored.
jimfulton Apr 30, 2021
e9c5175
Better binary-literal hack
jimfulton May 3, 2021
7835d2c
added tests for BIGNUMERIC.
jimfulton May 3, 2021
dda37eb
Major rework using pickle to overcome type differences.
jimfulton May 3, 2021
b774f79
Added array support
jimfulton May 3, 2021
7a31d12
blacken
jimfulton May 3, 2021
78be3cf
replaced an unreachable branch with an assert.
jimfulton May 3, 2021
297e532
lint
jimfulton May 3, 2021
0adebe1
Enable generation of random primary keys when running compliance tests.
jimfulton May 3, 2021
21121e9
Run the select a couple of ways and assert result.
jimfulton May 3, 2021
b942a61
Only generate random primary keys when running compliance tests.
jimfulton May 3, 2021
4aeb0db
addd fetchall, needed by a test.
jimfulton May 4, 2021
a8add9e
Port compliance tests
jimfulton May 4, 2021
04aaee4
record when array size is set.
jimfulton May 4, 2021
0e081a0
Added a tiny metadata convenience.
jimfulton May 4, 2021
6fe196e
Added arraysize tests.
jimfulton May 4, 2021
67733fd
exercise labels
jimfulton May 4, 2021
725c5d5
Make sure label names are legal identifiers
jimfulton May 4, 2021
cb56463
test disable quoting
jimfulton May 4, 2021
58c3d55
simplifed a test.
jimfulton May 4, 2021
d8e464a
Test forcing quote (even though quotes are forced anyway)
jimfulton May 4, 2021
fabd4c6
Be more careful about doubled %s.
jimfulton May 4, 2021
5cf4009
ported test for %%s
jimfulton May 4, 2021
33642ff
Added IN tests.
jimfulton May 4, 2021
401ad3b
handle UNNEST
jimfulton May 4, 2021
2313f54
"inlined" some helper attrs
jimfulton May 4, 2021
7e57563
moved setup_table to central location
jimfulton May 4, 2021
534a819
ported a test that deals with bind params with indeterminate types
jimfulton May 4, 2021
32f6b95
leverage setup_table
jimfulton May 4, 2021
c762a9c
added a test based on sqlalchemy.testing.suite.test_select.LikeFuncti…
jimfulton May 4, 2021
492530b
leverage setup_table
jimfulton May 4, 2021
15ba275
Added test for labels in group by
jimfulton May 4, 2021
a65bd1a
Added a test for compiling a single column.
jimfulton May 5, 2021
ab873aa
Trying to compile a nameless column gives a meaningful error.
jimfulton May 5, 2021
b1224c3
Get 100% coverage of fauxdbi
jimfulton May 5, 2021
ba21553
Simplified quote decision.
jimfulton May 5, 2021
445832e
Specify proto 4 when pickling, to get predictable behavior across Pyt…
jimfulton May 5, 2021
2ef50bd
Some tests require sqlalchemy 1.3
jimfulton May 5, 2021
5cd127a
require 100% test coverage.
jimfulton May 5, 2021
ed81f2c
need newer sqlalchemy and google-auth
jimfulton May 5, 2021
28e4f40
need sqlalchemy 1.2 because comments.
jimfulton May 5, 2021
9616813
blacken/lint
jimfulton May 5, 2021
0b1e85e
Added code to cleanup schemas at start to avoid spurious errors.
jimfulton May 5, 2021
00d61f4
added copyright
jimfulton May 5, 2021
c58f5f1
added copyright
jimfulton May 5, 2021
7e826e1
fixed copyright
jimfulton May 5, 2021
b469f3f
Updated the compliance setup
jimfulton May 5, 2021
c021366
added copyright
jimfulton May 5, 2021
5af39be
added copyright
jimfulton May 5, 2021
a2e92a3
added copyright
jimfulton May 5, 2021
e85558b
added copyright
jimfulton May 5, 2021
c683b52
added copyright
jimfulton May 5, 2021
b7bc62b
blacken
jimfulton May 5, 2021
69c1d40
merge master
jimfulton May 5, 2021
62d8df2
Make operational errors more informative.
jimfulton May 5, 2021
b2ac135
Fixed better debugging support.
jimfulton May 6, 2021
e5e9786
lint first
jimfulton May 6, 2021
9aa57c2
vargify unuded arguments to avoid spurious sqlalchemy 1.4 error.
jimfulton May 6, 2021
250332b
support sqlalchemy 1.4
jimfulton May 6, 2021
9963202
fetchall should return a sequence, not an iterable.
jimfulton May 6, 2021
c280c1f
sqlalchemy url parameters are now immutable
jimfulton May 6, 2021
7625e61
Don't use upsert to update comments.
jimfulton May 6, 2021
988a0e9
use the default value of returns_unicode_strings
jimfulton May 6, 2021
410b9ac
Older sqlite don't have true and false.
jimfulton May 6, 2021
0b8e3f0
Ignore test debugging info added to deal with sqlite3 differences.
jimfulton May 6, 2021
fa303d7
blacken
jimfulton May 6, 2021
1589a5e
Deal with differences in the way "expanding" is handled in sqlalchemy…
jimfulton May 6, 2021
bbb0b54
Added skips for before and after sqlalchemy 1.4
jimfulton May 6, 2021
0d2169a
Updated tests for sqlalchemy 1.4
jimfulton May 6, 2021
89036ce
blacken
jimfulton May 6, 2021
899300b
Be much more careful about inserting types in placeholders.
jimfulton May 7, 2021
e9a1378
Consider bind param expanding status
jimfulton May 7, 2021
5ce7507
Added a nutty registration to make sqlalchemy 1.4's dialect-testing m…
jimfulton May 7, 2021
3c4c8c7
Made delete handling (in teardown) robust for different sqlalchemy ve…
jimfulton May 7, 2021
3667869
skipped some more tests
jimfulton May 7, 2021
87f2846
Added minimal requirement for google-api-core to be consistent with s…
jimfulton May 10, 2021
dc28277
Make the google-auth requirement consistent with the Python 3.6 test …
jimfulton May 10, 2021
159fd18
chore(revert): revert preventing normalization (#132)
dandhlee Apr 27, 2021
05528af
Explain why we add where clauses in delete statements that lack them
jimfulton May 10, 2021
2db2dd4
Added a missing _ and explained \d+s in a regex
jimfulton May 10, 2021
8ea13de
Fixed: didn't properly handle expansion of single-item arrays.
jimfulton May 10, 2021
ae03721
Added test for expansion of single-element arrays
jimfulton May 10, 2021
486873b
Avoid having to use an `_` to ignore a re group we don't care about.
jimfulton May 10, 2021
a897d60
Added some comments for the tricky _get_field method.
jimfulton May 10, 2021
6e4d5d6
Commented the pickle-protocol 4 prefixes we're looking for.
jimfulton May 10, 2021
708f5db
explain use of pickle.
jimfulton May 10, 2021
eeaae87
typo
jimfulton May 10, 2021
ce6181f
BigQuery 2.15 wants google-api-core >= 1.23.0
jimfulton May 10, 2021
877106b
blacken
jimfulton May 10, 2021
2a25233
BQ requires limits and offsets to be literals.
jimfulton May 10, 2021
6dbf222
Skip test for features that BQ doesn't handle. Also fix a test.
jimfulton May 10, 2021
db7a04f
Correct meaning of UNION and don't expand when arameter type is unknown.
jimfulton May 10, 2021
ddd3399
don't need to call out the project in the test config.
jimfulton May 10, 2021
e063e3e
Try sleeping between tests to see if we can avoid some weird failures.
jimfulton May 10, 2021
7530acf
some minimal docs on the dialect tests.
jimfulton May 10, 2021
4d99090
Update tests/sqlalchemy_dialect_compliance/README.rst
jimfulton May 11, 2021
6b2a6b6
Update tests/sqlalchemy_dialect_compliance/README.rst
jimfulton May 11, 2021
bc40df2
simplify by getting rid of unnecessary and broken overrriding.
jimfulton May 11, 2021
ec4961c
merge upstream
jimfulton May 11, 2021
16e302d
Try sleeping longer to avoid races between tests.
jimfulton May 11, 2021
6793760
Got RowCountTest passing
jimfulton May 11, 2021
1e11ce2
make sure we wait for the drops at the beginning of the session.
jimfulton May 11, 2021
ff35acf
rerun on table not found
jimfulton May 11, 2021
b4c3c23
Try simpler regex
jimfulton May 11, 2021
18ebe26
Try different error
jimfulton May 11, 2021
fbbd563
don't sleep between tests.
jimfulton May 11, 2021
a103ae8
blacken
jimfulton May 11, 2021
5809a9c
removed unused import
jimfulton May 11, 2021
b882818
Don't enable the unicode ddl tests. They create invalid column names.
jimfulton May 12, 2021
7ee98be
fix more tests
jimfulton May 12, 2021
4728f5e
merge master
jimfulton May 12, 2021
bd9d688
Removed machinery to clean tests schemas
jimfulton May 12, 2021
0fa700f
Added an alternate requirements class that skips schema tests.
jimfulton May 12, 2021
43fe9b8
use --dropfirst to clean test schemas at start of compliance run.
jimfulton May 12, 2021
5eae34c
merge master
jimfulton May 12, 2021
1f1a510
really merge master
jimfulton May 12, 2021
c0b742d
document running test simultaneously
jimfulton May 12, 2021
cabffb1
Merge remote-tracking branch 'origin/master' into riversnake-sqla-14
jimfulton May 12, 2021
fff1811
Merged changes to facilitate simultaneous test runs
jimfulton May 12, 2021
d5251ce
fixed merge misfire.
jimfulton May 12, 2021
0b7e193
blacken
jimfulton May 12, 2021
ff3b4fc
removed unused import
jimfulton May 12, 2021
d3f5b7c
removed repeated function definition.
jimfulton May 12, 2021
de6a514
import cleanup and lint
jimfulton May 12, 2021
a83fc85
In sqlite3 UNION DISTINCT is spelled UNION
jimfulton May 12, 2021
c11a3c3
Use newer BQ that has sane executemany rowcount
jimfulton May 13, 2021
634b824
Added a helper to make it easier to manage regex substitutions
jimfulton May 13, 2021
6a53bcb
update BQ
jimfulton May 13, 2021
fd65861
Updated placeholder handling for 1.4
jimfulton May 13, 2021
dc74972
Changed am expectation for 1.4.
jimfulton May 13, 2021
863ef00
merge master
jimfulton May 13, 2021
d2eefa4
We'll always be passed a string that needs to be compiled.
jimfulton May 13, 2021
00ea3ab
notin needs to wrap its result in ()s
jimfulton May 16, 2021
d47a57b
use functools.wraps
jimfulton May 16, 2021
78c3056
Added a test for a gnarly regex
jimfulton May 16, 2021
8e5cea6
Fixed a regex
jimfulton May 16, 2021
2d42d71
adjused some expectations for `not in` being wrapped in ()s
jimfulton May 16, 2021
7a802ee
moar cases
jimfulton May 16, 2021
80f1ee9
Update expectation: we now encode not-in expressions in ()s.
jimfulton May 16, 2021
7596f6d
We can still run with sqla 1.3
jimfulton May 16, 2021
dc21cbf
use more substitute_re_method
jimfulton May 16, 2021
d17c2f0
leverage substitute_re_method
jimfulton May 16, 2021
ff11a31
replaced some unreached paths with assertions.
jimfulton May 17, 2021
08c781c
ported a compliance test to hit an unreached path.
jimfulton May 17, 2021
e06fac2
different sql is generated for `in` before and after 1.4
jimfulton May 17, 2021
ce87a54
made substitute_re_method more methody
jimfulton May 17, 2021
da3ce60
brought back some code paths needed by sqlalchemy 1.3
jimfulton May 17, 2021
26c16a7
make sure we test 1.3
jimfulton May 17, 2021
6996562
lint/blacken
jimfulton May 17, 2021
55ecde6
Merge branch 'master' into riversnake-sqla-14
jimfulton May 17, 2021
9ae173a
removed some no-longer relevant text
jimfulton May 17, 2021
d0edaea
Merge branch 'master' into riversnake-sqla-14
jimfulton May 18, 2021
2c5d992
Removed breakpoint from code that should never be called. :)
jimfulton May 19, 2021
070814e
run system and compliance tests with both sqla 1.3 and 1.4
jimfulton May 19, 2021
0fc9db6
be more careful about sqlalchemy version comparison
jimfulton May 21, 2021
64206c0
use wraps as a decorator
jimfulton May 21, 2021
41edaa5
say why we're using 2 python versions
jimfulton May 21, 2021
738faa0
blacken
jimfulton May 21, 2021
4d80d23
don't wait for compliance tests to finish to find out we have a lint …
jimfulton May 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion pybigquery/_helpers.py
Expand Up @@ -69,4 +69,14 @@ def substitute_re_method(r, flags=0, repl=None):

r = re.compile(r, flags)

return functools.wraps(repl)(lambda self, s: r.sub(repl, s))
if isinstance(repl, str):
return lambda self, s: r.sub(repl, s)

def sub(self, s, *args, **kw):

def repl_(m):
return repl(self, m, *args, **kw)

return r.sub(repl_, s)

return functools.wraps(repl)(sub)
plamut marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion pybigquery/sqlalchemy_bigquery.py
Expand Up @@ -177,7 +177,7 @@ def get_insert_default(self, column): # pragma: NO COVER
r" \]\)",
re.IGNORECASE,
)
def __distribute_types_to_expanded_placeholders(m):
def __distribute_types_to_expanded_placeholders(self, m):
# If we have an in parameter, it sometimes gets expaned to 0 or more
# parameters and we need to move the type marker to each
# parameter.
Expand Down
66 changes: 32 additions & 34 deletions tests/unit/fauxdbi.py
Expand Up @@ -87,19 +87,18 @@ def arraysize(self, v):
datetime.time,
)

@substitute_re_method(r"%\((\w+)\)s", re.IGNORECASE)
def __pyformat_to_qmark(self, m, parameters, ordered_parameters):
name = m.group(1)
value = parameters[name]
if isinstance(value, self._need_to_be_pickled):
value = pickle.dumps(value, 4).decode("latin1")
ordered_parameters.append(value)
return "?"

def __convert_params(self, operation, parameters):
ordered_parameters = []

@substitute_re_method(r"%\((\w+)\)s", re.IGNORECASE)
def pyformat_to_qmark(m):
name = m.group(1)
value = parameters[name]
if isinstance(value, self._need_to_be_pickled):
value = pickle.dumps(value, 4).decode("latin1")
ordered_parameters.append(value)
return "?"

operation = pyformat_to_qmark(self, operation)
operation = self.__pyformat_to_qmark(operation, parameters, ordered_parameters)
return operation, ordered_parameters

def __update_comment(self, table, col, comment):
Expand All @@ -111,6 +110,26 @@ def __update_comment(self, table, col, comment):
r"\s*create\s+table\s+`(?P<table>\w+)`", re.IGNORECASE
).match

@substitute_re_method(
r"(?P<prefix>`(?P<col>\w+)`\s+\w+|\))"
r"\s+options\((?P<options>[^)]+)\)",
re.IGNORECASE)
def __handle_column_comments(self, m, table_name):
col = m.group("col") or ""
options = {
name.strip().lower(): value.strip()
for name, value in (
o.split("=") for o in m.group("options").split(",")
)
}

comment = options.get("description")
if comment:
self.__update_comment(table_name, col, comment)

return m.group("prefix")


def __handle_comments(
self,
operation,
Expand All @@ -122,28 +141,7 @@ def __handle_comments(
):
m = self.__create_table(operation)
if m:
table_name = m.group("table")

@substitute_re_method(
r"(?P<prefix>`(?P<col>\w+)`\s+\w+|\))"
r"\s+options\((?P<options>[^)]+)\)",
re.IGNORECASE)
def handle_column_comments(m):
col = m.group("col") or ""
options = {
name.strip().lower(): value.strip()
for name, value in (
o.split("=") for o in m.group("options").split(",")
)
}

comment = options.get("description")
if comment:
self.__update_comment(table_name, col, comment)

return m.group("prefix")

return handle_column_comments(self, operation)
return self.__handle_column_comments(operation, m.group("table"))

m = alter_table(operation)
if m:
Expand All @@ -158,7 +156,7 @@ def handle_column_comments(m):
r"(?<=[(,])" r"\s*`\w+`\s+\w+<\w+>\s*"
r"(?=[,)])",
re.IGNORECASE)
def __normalize_array_types(m):
def __normalize_array_types(self, m):
return m.group(0).replace("<", "_").replace(">", "_")

def __handle_array_types(
Expand Down
38 changes: 32 additions & 6 deletions tests/unit/test_helpers.py
Expand Up @@ -138,22 +138,48 @@ def mock_default_credentials(*args, **kwargs):
assert bqclient.project == "connection-url-project"


def test_substitute_re(module_under_test):
def test_substitute_re_string(module_under_test):
import re

foo_to_baz = module_under_test.substitute_re_method("foo", re.IGNORECASE, "baz")
assert foo_to_baz(object(), "some foo and FOO is good") == "some baz and baz is good"


def test_substitute_re_func(module_under_test):
import re

@module_under_test.substitute_re_method("foo", re.IGNORECASE)
def Foo_to_bar(m):
def Foo_to_bar(self, m):
return 'bar'

assert Foo_to_bar(object(), "some foo and FOO is good") == "some bar and bar is good"

@module_under_test.substitute_re_method("foo")
def foo_to_bar(m):
return 'bar'
def foo_to_bar(self, m, x='bar'):
return x

assert foo_to_bar(object(), "some foo and FOO is good") == "some bar and FOO is good"

foo_to_baz = module_under_test.substitute_re_method("foo", re.IGNORECASE, "baz")
assert foo_to_baz(object(), "some foo and FOO is good") == "some baz and baz is good"
assert foo_to_bar(object(), "some foo and FOO is good", 'hah'
) == "some hah and FOO is good"

assert foo_to_bar(object(), "some foo and FOO is good", x='hah'
) == "some hah and FOO is good"

assert foo_to_bar.__name__ == 'foo_to_bar'


def test_substitute_re_func_self(module_under_test):
import re

class Replacer:

def __init__(self, x):
self.x = x

@module_under_test.substitute_re_method("foo")
def foo_to_bar(self, m):
return self.x

assert Replacer('hah').foo_to_bar("some foo and FOO is good"
) == "some hah and FOO is good"