Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Comment/description support, bug fixes and better test coverage #138

Merged
merged 159 commits into from May 12, 2021
Merged

feat: Comment/description support, bug fixes and better test coverage #138

merged 159 commits into from May 12, 2021

Commits on Apr 12, 2021

  1. Fixed a dependency problem that caysed test failures in Python 3.6. 

    The source of the dependency bug is in old versions of google-cloud-core that
depend on too-old versions of google-api-core.
    @jimfulton
    jimfulton committed Apr 12, 2021
    Copy the full SHA
    0fc64fa View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Started implementing SqlAlchemy dialect-compliance tests 

    Some tests are still failing, but
we're far enough along that we have the right shape, I think.
    @jimfulton
    jimfulton committed Apr 15, 2021
    Copy the full SHA
    bfdda68 View commit details
    Browse the repository at this point in the history

  2. Handle parameters in in 

    The moral equivalent of    "where foo in (@bar)", where bar is an array
which actually need to be  "where foo in unnest (@bar)".
    @jimfulton
    jimfulton committed Apr 15, 2021
    Copy the full SHA
    41cb2dd View commit details
    Browse the repository at this point in the history

  3. fixed regex to allow multi-character parameter names. 

    Doh!
    @jimfulton
    jimfulton committed Apr 15, 2021
    Copy the full SHA
    631c060 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Fixed rendering of string literals.

    @jimfulton
    jimfulton committed Apr 16, 2021
    Copy the full SHA
    aa85cb9 View commit details
    Browse the repository at this point in the history

  2. Provide default values for primary keys and other fixes... 

    Other fixes:
- Handle BIGINT
- Fix string leteral formatting (and start type-specific adaptations).
    @jimfulton
    jimfulton committed Apr 16, 2021
    Copy the full SHA
    c7da257 View commit details
    Browse the repository at this point in the history

  3. Narrowed skips and license comment diagnosed reasons for skipped fail… 

    …ures
    @jimfulton
    jimfulton committed Apr 16, 2021
    Copy the full SHA
    3916239 View commit details
    Browse the repository at this point in the history

  4. use Google license

    @jimfulton
    jimfulton committed Apr 16, 2021
    Copy the full SHA
    46b30b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Fixed like (% and _) escapes. 

    The SQLAlchemy like convenience functions (e.g. ) escape incorrectly for
BigQuery, so re-escape.
    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    36a0033 View commit details
    Browse the repository at this point in the history

  2. Handle BIGNUMERIC

    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    d079fbe View commit details
    Browse the repository at this point in the history

  3. Skip tests that want to stpre floats as numeric. 

    We could make that work, if we want to. :)
    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    7e60691 View commit details
    Browse the repository at this point in the history

  4. skip tests for offsets without limits. BigQuery doesn't allow that.

    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    4a1bafd View commit details
    Browse the repository at this point in the history

  5. BIGNUMERIC lets us handle many significant digits.test_many_significa… 

    …nt_digits
    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    e07b1f0 View commit details
    Browse the repository at this point in the history

  6. Skip LongNameBlowoutTest because it requires features (indexes, prima… 

    …ry keys, etc., that BigQuery doesn't have.
    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    656af06 View commit details
    Browse the repository at this point in the history

  7. We have to rewrite these tests, because of forcing use_labels=True 

    #78
    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    a085db6 View commit details
    Browse the repository at this point in the history

  8. BigQuery returns deleted and updated rows, which SQLAlchemy doesn't e… 

    …xpect
    @jimfulton
    jimfulton committed Apr 19, 2021
    Copy the full SHA
    681ea47 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Fixed a dependency problem that caysed test failures in Python 3.6. 

    The source of the dependency bug is in old versions of google-cloud-core that
depend on too-old versions of google-api-core.
    @jimfulton
    jimfulton committed Apr 20, 2021
    Copy the full SHA
    cde5bf8 View commit details
    Browse the repository at this point in the history

  2. Provide a bigquery mock based on sqlite 

    So we don't have t mock at the api level.
    @jimfulton
    jimfulton committed Apr 20, 2021
    Copy the full SHA
    76cf078 View commit details
    Browse the repository at this point in the history

  3. Don't force labels in select. 

    #78
    @jimfulton
    jimfulton committed Apr 20, 2021
    Copy the full SHA
    ee46a1e View commit details
    Browse the repository at this point in the history

  4. merge riversnake-fix-78

    @jimfulton
    jimfulton committed Apr 20, 2021
    Copy the full SHA
    62432a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. No need to work around forced labels anymore.

    @jimfulton
    jimfulton committed Apr 22, 2021
    Copy the full SHA
    a54b946 View commit details
    Browse the repository at this point in the history

  2. Updated sqlite-bases mock 

    - Run tests in temporary directory rather than sharing memory connections.
  Because simpler. :)
- Introduce cross-connection state and record queries in it, so tests can
  make assertions bout generated queries.
    @jimfulton
    jimfulton committed Apr 22, 2021
    Copy the full SHA
    1320f32 View commit details
    Browse the repository at this point in the history

  3. Added test that types are injected into parameter placeholders.

    @jimfulton
    jimfulton committed Apr 22, 2021
    Copy the full SHA
    4f098fd View commit details
    Browse the repository at this point in the history

  4. Oops, need to call super even when there are where clauses.

    @jimfulton
    jimfulton committed Apr 22, 2021
    Copy the full SHA
    2c76342 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. When SQLAlchemy thinks it knows a parameter type, include it in the p… 

    …laceholder

The BigQuery Python Client supports an extended placeholder syntax
that includes type information, as in `%(foo:INT64)s` (named) or
`%(:INT64)s` (unnamed).

When we know the type, include it in the placeholder.
    @jimfulton
    jimfulton committed Apr 23, 2021
    Copy the full SHA
    68f9043 View commit details
    Browse the repository at this point in the history

  2. Don't skip some numeric tests and skip some CTE tests 

    The numeric tests now tun since we started passing type info from sqla to bigquery.

The CTE tests test features that don't exist in bigquery.
    @jimfulton
    jimfulton committed Apr 23, 2021
    Copy the full SHA
    be1e215 View commit details
    Browse the repository at this point in the history

  3. Can't coerce datetime to date.

    @jimfulton
    jimfulton committed Apr 23, 2021
    Copy the full SHA
    39f1955 View commit details
    Browse the repository at this point in the history

  4. reenable some tests now that we pass type infor to bigquery

    @jimfulton
    jimfulton committed Apr 23, 2021
    Copy the full SHA
    9e266f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Enable error on warnings -- a test depends on it. 

    Although the test isn't actually testing dialect code.  Maybe it
should be skipped instead.

Also set the profile test pasth to a more reasonable value, although
it doesn't seem to be used. <shrug>
    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    fa84c95 View commit details
    Browse the repository at this point in the history

  2. Added table and column comment support. 

    Also inlined colspecs code, because there wasn't much and it
facilitated separating literal processing into a function.
    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    b01d2ce View commit details
    Browse the repository at this point in the history

  3. get_schema_names should return all of the schema names. 

    The tests don't disagree. :)
    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    dc91449 View commit details
    Browse the repository at this point in the history

  4. Retrieval of view definitions.

    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    3743abe View commit details
    Browse the repository at this point in the history

  5. handle dateish literals.

    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    dcc7e45 View commit details
    Browse the repository at this point in the history

  6. BigQuery doesn't want schema names in column names.

    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    163d031 View commit details
    Browse the repository at this point in the history

  7. Allow mutating table descriptions/comments.

    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    c47a83d View commit details
    Browse the repository at this point in the history

  8. skip tests that depend on BigQuery keeping track of column details. 

    Like precision, length, etc.
    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    9444c20 View commit details
    Browse the repository at this point in the history

  9. Handle TIMESTAMP literals.

    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    30c8ed7 View commit details
    Browse the repository at this point in the history

  10. Fixed some broken TIMESTAMP tests. 

    Also, removed some unneeded imports.
    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    0ef4909 View commit details
    Browse the repository at this point in the history

  11. enabled more tests.

    @jimfulton
    jimfulton committed Apr 24, 2021
    Copy the full SHA
    99629cf View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. remove extra lines.

    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    5e6e48d View commit details
    Browse the repository at this point in the history

  2. blacken

    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    83feb1e View commit details
    Browse the repository at this point in the history

  3. added missing test for api.py

    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    896a082 View commit details
    Browse the repository at this point in the history

  4. Ignore flake8 complaint about * import. 

    The names are known and used by pytest.
    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    497cc90 View commit details
    Browse the repository at this point in the history

  5. lint and minor cleanup

    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    7e5399a View commit details
    Browse the repository at this point in the history

  6. Removed unused variable.

    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    e48dd58 View commit details
    Browse the repository at this point in the history

  7. Get to 100% coverage in test_parse_url 

    - Test cases with one param set to reach an uncovered branch for write disposition.

- Test parsing false.
    @jimfulton
    jimfulton committed Apr 26, 2021
    Copy the full SHA
    395a2d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Don't need because we can't test temp tables 

    Because bigquery only supports temp tables in scripts.
    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    07af7ef View commit details
    Browse the repository at this point in the history

  2. requirements.py -- It's used by compliance testing.

    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    ea99108 View commit details
    Browse the repository at this point in the history

  3. Added Binary literal handling, and ... 

    also:

- Added missing small int.
- Renamed `process_literal` to `process_string_literal`
- some reformating.
    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    7039f05 View commit details
    Browse the repository at this point in the history

  4. Updated fauxdb to correct for some sqlite differences. 

    Also, rearraged conftest and the faux_conn fixture a bit
to reuse sqlite connections and to go back to a memory connection.
    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    0f2d315 View commit details
    Browse the repository at this point in the history

  5. Fixed santy check

    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    9db1e3b View commit details
    Browse the repository at this point in the history

  6. blackened

    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    50e3448 View commit details
    Browse the repository at this point in the history

  7. Added a test that exercises type handling for all the types. 

    (Replaced a simper test.)
    @jimfulton
    jimfulton committed Apr 27, 2021
    Copy the full SHA
    f449c5e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Added table reference tests

    @jimfulton
    jimfulton committed Apr 28, 2021
    Copy the full SHA
    d000075 View commit details
    Browse the repository at this point in the history

  2. test get_view_definition

    @jimfulton
    jimfulton committed Apr 28, 2021
    Copy the full SHA
    190136e View commit details
    Browse the repository at this point in the history

  3. removed a private function that's never called.

    @jimfulton
    jimfulton committed Apr 28, 2021
    Copy the full SHA
    acdd4d2 View commit details
    Browse the repository at this point in the history

  4. table and view list tests

    @jimfulton
    jimfulton committed Apr 28, 2021
    Copy the full SHA
    3e73a0a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Moar unit tests and coverage

    @jimfulton
    jimfulton committed Apr 29, 2021
    Copy the full SHA
    4c6d72d View commit details
    Browse the repository at this point in the history

  2. use latest bg release, because we depend on changes there.

    @jimfulton
    jimfulton committed Apr 29, 2021
    Copy the full SHA
    349269f View commit details
    Browse the repository at this point in the history

  3. removed breakpoint that shouldn't have been checked in.

    @jimfulton
    jimfulton committed Apr 29, 2021
    Copy the full SHA
    717dd77 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Bypass google authentication. 

    Also, simplify wireing of faux connections and clients.
    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    7ba7813 View commit details
    Browse the repository at this point in the history

  2. Test JSON deserialization.

    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    c22565e View commit details
    Browse the repository at this point in the history

  3. Test getting project id from authentication.

    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    dc246ae View commit details
    Browse the repository at this point in the history

  4. removed some unneeded code. 

    String literals in bq can start with ".
    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    b914ee3 View commit details
    Browse the repository at this point in the history

  5. Simplify string and binary literal processors to not expect None. 

    It can't happen.
    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    a7e49e9 View commit details
    Browse the repository at this point in the history

  6. Tested comment support

    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    53883d5 View commit details
    Browse the repository at this point in the history

  7. Cleaned up comment handling. 

    BTW column.doc is a Python docs thing for the ORM, not a database level comment/description.
    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    5b1e77e View commit details
    Browse the repository at this point in the history

  8. generalized options handling.

    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    beaf0b6 View commit details
    Browse the repository at this point in the history

  9. test dialect-options handling.

    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    8236d5b View commit details
    Browse the repository at this point in the history

  10. constraints are ignored.

    @jimfulton
    jimfulton committed Apr 30, 2021
    Copy the full SHA
    8e41b4d View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Better binary-literal hack

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    e9c5175 View commit details
    Browse the repository at this point in the history

  2. added tests for BIGNUMERIC.

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    7835d2c View commit details
    Browse the repository at this point in the history

  3. Major rework using pickle to overcome type differences.

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    dda37eb View commit details
    Browse the repository at this point in the history

  4. Added array support

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    b774f79 View commit details
    Browse the repository at this point in the history

  5. blacken

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    7a31d12 View commit details
    Browse the repository at this point in the history

  6. replaced an unreachable branch with an assert.

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    78be3cf View commit details
    Browse the repository at this point in the history

  7. lint

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    297e532 View commit details
    Browse the repository at this point in the history

  8. Enable generation of random primary keys when running compliance tests. 

    Because the tests expect tables to have primary keys that het provided somehow.
    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    0adebe1 View commit details
    Browse the repository at this point in the history

  9. Run the select a couple of ways and assert result.

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    21121e9 View commit details
    Browse the repository at this point in the history

  10. Only generate random primary keys when running compliance tests.

    @jimfulton
    jimfulton committed May 3, 2021
    Copy the full SHA
    b942a61 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. addd fetchall, needed by a test.

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    4aeb0db View commit details
    Browse the repository at this point in the history

  2. Port compliance tests 

    For unit-test coverage. :)
    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    a8add9e View commit details
    Browse the repository at this point in the history

  3. record when array size is set.

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    04aaee4 View commit details
    Browse the repository at this point in the history

  4. Added a tiny metadata convenience. 

    A convenience here, a convenience there ...
    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    0e081a0 View commit details
    Browse the repository at this point in the history

  5. Added arraysize tests.

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    6fe196e View commit details
    Browse the repository at this point in the history

  6. exercise labels

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    67733fd View commit details
    Browse the repository at this point in the history

  7. Make sure label names are legal identifiers

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    725c5d5 View commit details
    Browse the repository at this point in the history

  8. test disable quoting

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    cb56463 View commit details
    Browse the repository at this point in the history

  9. simplifed a test.

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    58c3d55 View commit details
    Browse the repository at this point in the history

  10. Test forcing quote (even though quotes are forced anyway)

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    d8e464a View commit details
    Browse the repository at this point in the history

  11. Be more careful about doubled %s.

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    fabd4c6 View commit details
    Browse the repository at this point in the history

  12. ported test for %%s

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    5cf4009 View commit details
    Browse the repository at this point in the history

  13. Added IN tests.

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    33642ff View commit details
    Browse the repository at this point in the history

  14. handle UNNEST

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    401ad3b View commit details
    Browse the repository at this point in the history

  15. "inlined" some helper attrs

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    2313f54 View commit details
    Browse the repository at this point in the history

  16. moved setup_table to central location

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    7e57563 View commit details
    Browse the repository at this point in the history

  17. ported a test that deals with bind params with indeterminate types

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    534a819 View commit details
    Browse the repository at this point in the history

  18. leverage setup_table

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    32f6b95 View commit details
    Browse the repository at this point in the history

  19. added a test based on sqlalchemy.testing.suite.test_select.LikeFuncti… 

    …onsTest
    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    c762a9c View commit details
    Browse the repository at this point in the history

  20. leverage setup_table

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    492530b View commit details
    Browse the repository at this point in the history

  21. Added test for labels in group by

    @jimfulton
    jimfulton committed May 4, 2021
    Copy the full SHA
    15ba275 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Added a test for compiling a single column. 

    Also,simplified other test using the metadata helper.
    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    a65bd1a View commit details
    Browse the repository at this point in the history

  2. Trying to compile a nameless column gives a meaningful error.

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    ab873aa View commit details
    Browse the repository at this point in the history

  3. Get 100% coverage of fauxdbi

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    b1224c3 View commit details
    Browse the repository at this point in the history

  4. Simplified quote decision. 

    We always quote unless told not to.

Also, exclude a method for getting default primary-key values. It's only used in compliance tests.
    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    ba21553 View commit details
    Browse the repository at this point in the history

  5. Specify proto 4 when pickling, to get predictable behavior across Pyt… 

    …hon versions
    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    445832e View commit details
    Browse the repository at this point in the history

  6. Some tests require sqlalchemy 1.3

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    2ef50bd View commit details
    Browse the repository at this point in the history

  7. require 100% test coverage.

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    5cd127a View commit details
    Browse the repository at this point in the history

  8. need newer sqlalchemy and google-auth 

    sqlalchemy because comments.

google-auth because we need very recent bigquery.
    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    ed81f2c View commit details
    Browse the repository at this point in the history

  9. need sqlalchemy 1.2 because comments.

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    28e4f40 View commit details
    Browse the repository at this point in the history

  10. blacken/lint

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    9616813 View commit details
    Browse the repository at this point in the history

  11. Added code to cleanup schemas at start to avoid spurious errors.

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    0b1e85e View commit details
    Browse the repository at this point in the history

  12. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    00d61f4 View commit details
    Browse the repository at this point in the history

  13. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    c58f5f1 View commit details
    Browse the repository at this point in the history

  14. fixed copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    7e826e1 View commit details
    Browse the repository at this point in the history

  15. Updated the compliance setup

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    b469f3f View commit details
    Browse the repository at this point in the history

  16. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    c021366 View commit details
    Browse the repository at this point in the history

  17. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    5af39be View commit details
    Browse the repository at this point in the history

  18. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    a2e92a3 View commit details
    Browse the repository at this point in the history

  19. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    e85558b View commit details
    Browse the repository at this point in the history

  20. added copyright

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    c683b52 View commit details
    Browse the repository at this point in the history

  21. blacken

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    b7bc62b View commit details
    Browse the repository at this point in the history

  22. merge master

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    69c1d40 View commit details
    Browse the repository at this point in the history

  23. Make operational errors more informative.

    @jimfulton
    jimfulton committed May 5, 2021
    Copy the full SHA
    62d8df2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Fixed better debugging support.

    @jimfulton
    jimfulton committed May 6, 2021
    Copy the full SHA
    b2ac135 View commit details
    Browse the repository at this point in the history

  2. lint first

    @jimfulton
    jimfulton committed May 6, 2021
    Copy the full SHA
    e5e9786 View commit details
    Browse the repository at this point in the history

  3. Don't use upsert to update comments. 

    The version of sqlite in the CI image doesn't support upsert.
    @jimfulton
    jimfulton committed May 6, 2021
    Copy the full SHA
    7625e61 View commit details
    Browse the repository at this point in the history

  4. Older sqlite don't have true and false.

    @jimfulton
    jimfulton committed May 6, 2021
    Copy the full SHA
    410b9ac View commit details
    Browse the repository at this point in the history

  5. Ignore test debugging info added to deal with sqlite3 differences.

    @jimfulton
    jimfulton committed May 6, 2021
    Copy the full SHA
    0b8e3f0 View commit details
    Browse the repository at this point in the history

  6. blacken

    @jimfulton
    jimfulton committed May 6, 2021
    Copy the full SHA
    fa303d7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Added minimal requirement for google-api-core to be consistent with s… 

    …etup.py.
    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    87f2846 View commit details
    Browse the repository at this point in the history

  2. Make the google-auth requirement consistent with the Python 3.6 test … 

    …constraint.

The test constraint was really diven by the requitements of other
requirements, not this package. <shrug>
    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    dc28277 View commit details
    Browse the repository at this point in the history

  3. chore(revert): revert preventing normalization (#132) 

    reverts previous commit for preventing normalization of versioning
    @dandhlee @jimfulton
    dandhlee authored and jimfulton committed May 10, 2021
    Copy the full SHA
    159fd18 View commit details
    Browse the repository at this point in the history

  4. Explain why we add where clauses in delete statements that lack them 

    but only during test cleanup.
    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    05528af View commit details
    Browse the repository at this point in the history

  5. Added a missing _ and explained \d+s in a regex

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    2db2dd4 View commit details
    Browse the repository at this point in the history

  6. Fixed: didn't properly handle expansion of single-item arrays.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    8ea13de View commit details
    Browse the repository at this point in the history

  7. Added test for expansion of single-element arrays

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    ae03721 View commit details
    Browse the repository at this point in the history

  8. Avoid having to use an _ to ignore a re group we don't care about.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    486873b View commit details
    Browse the repository at this point in the history

  9. Added some comments for the tricky _get_field method.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    a897d60 View commit details
    Browse the repository at this point in the history

  10. Commented the pickle-protocol 4 prefixes we're looking for.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    6e4d5d6 View commit details
    Browse the repository at this point in the history

  11. explain use of pickle.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    708f5db View commit details
    Browse the repository at this point in the history

  12. typo

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    eeaae87 View commit details
    Browse the repository at this point in the history

  13. BigQuery 2.15 wants google-api-core >= 1.23.0

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    ce6181f View commit details
    Browse the repository at this point in the history

  14. blacken

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    877106b View commit details
    Browse the repository at this point in the history

  15. don't need to call out the project in the test config. 

    We get it from the creds.
    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    ddd3399 View commit details
    Browse the repository at this point in the history

  16. Try sleeping between tests to see if we can avoid some weird failures.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    e063e3e View commit details
    Browse the repository at this point in the history

  17. some minimal docs on the dialect tests.

    @jimfulton
    jimfulton committed May 10, 2021
    Copy the full SHA
    7530acf View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Update tests/sqlalchemy_dialect_compliance/README.rst 

    Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
    @jimfulton @plamut
    jimfulton and plamut committed May 11, 2021
    Copy the full SHA
    4d99090 View commit details
    Browse the repository at this point in the history

  2. Update tests/sqlalchemy_dialect_compliance/README.rst 

    Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
    @jimfulton @plamut
    jimfulton and plamut committed May 11, 2021
    Copy the full SHA
    6b2a6b6 View commit details
    Browse the repository at this point in the history

  3. simplify by getting rid of unnecessary and broken overrriding.

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    bc40df2 View commit details
    Browse the repository at this point in the history

  4. merge upstream

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    ec4961c View commit details
    Browse the repository at this point in the history

  5. Try sleeping longer to avoid races between tests.

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    16e302d View commit details
    Browse the repository at this point in the history

  6. make sure we wait for the drops at the beginning of the session. 

    And get rid of the sleep, at least termporarily.
    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    1e11ce2 View commit details
    Browse the repository at this point in the history

  7. rerun on table not found

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    ff35acf View commit details
    Browse the repository at this point in the history

  8. Try simpler regex

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    b4c3c23 View commit details
    Browse the repository at this point in the history

  9. Try different error

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    18ebe26 View commit details
    Browse the repository at this point in the history

  10. don't sleep between tests. 

    It didn't buy us anything.
    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    fbbd563 View commit details
    Browse the repository at this point in the history

  11. blacken

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    a103ae8 View commit details
    Browse the repository at this point in the history

  12. removed unused import

    @jimfulton
    jimfulton committed May 11, 2021
    Copy the full SHA
    5809a9c View commit details
    Browse the repository at this point in the history