Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pip check on conda forge dependencies #723

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import re
import shutil
import warnings
import subprocess

import nox

Expand Down Expand Up @@ -598,6 +599,10 @@ def conda_test(session):
# for troubleshooting purposes.
session.run("mamba", "list")

subprocess.run(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiraksi

Please add a brief comment regarding why we chose to use subprocess.run() instead of using a session.run() command so that future me won't have to dig around in my memory banks.

Thanks.

["pip", "check"], check=True
) # Raise an exception if pip check fails

# Tests are limited to unit tests only, at this time.
session.run(
"py.test",
Expand Down