Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pip check on conda forge dependencies #723

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: pip check on conda forge dependencies #723

wants to merge 6 commits into from

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Jan 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #602 馃

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Jan 11, 2024
chalmerlowe
chalmerlowe requested changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add requested comment, thanks!

noxfile.py
@@ -598,6 +599,10 @@ def conda_test(session):
# for troubleshooting purposes.
session.run("mamba", "list")

subprocess.run(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiraksi

Please add a brief comment regarding why we chose to use subprocess.run() instead of using a session.run() command so that future me won't have to dig around in my memory banks.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please run pip check on the "conda" based tests
2 participants
@kiraksi @chalmerlowe