Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

build: exclude README from generated code #117

Merged
merged 1 commit into from Mar 17, 2021
Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 17, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Follow-up to #114 where I reverted changes to README manually

@tswast tswast requested review from a team and steffnay and removed request for a team March 17, 2021 17:15
@product-auto-label product-auto-label bot added the api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. label Mar 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@tswast tswast requested review from busunkim96 and shollyman and removed request for steffnay March 17, 2021 17:15
@tswast
Copy link
Contributor Author

tswast commented Mar 17, 2021

Tested manually with python -m synthtool and verified that README was not modified.

There was a change to noxfile.py, but I'll let autosynth pick that up.

@tswast tswast merged commit eaa23c1 into master Mar 17, 2021
@tswast tswast deleted the tswast-exclude-readme branch March 17, 2021 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants