Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AsyncHTTPIterator to page_iterators_async #629

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kiraksi
Copy link

@kiraksi kiraksi commented Mar 14, 2024

This PR:

  • Creates an AsyncHTTPIterator that can be used for async iterators in client libraries, in bigquery it will be used as the parent class of AsyncRowIterator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #627 馃

@kiraksi kiraksi requested review from a team as code owners March 14, 2024 02:38
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Mar 14, 2024
@kiraksi kiraksi changed the title feat: Add AsyncHTTPIterator to page_iterators feat: Add AsyncHTTPIterator to page_iterators_async Mar 14, 2024
@parthea parthea assigned parthea and ohmayr and unassigned parthea Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an AsyncHTTPIterator
3 participants