Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handlers for Cancelled and StopIteration in bidi.BackgroundConsumer #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dhendry
Copy link

@dhendry dhendry commented Feb 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #619 🦕

@dhendry dhendry requested review from a team as code owners February 21, 2024 20:55
Copy link

google-cla bot commented Feb 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vchudnov-g
Copy link
Contributor

Thanks for reporting the bugs and crafting this PR! We'll review these shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor termination handling in bidi.BackgroundConsumer resulting in error logs
3 participants