feat: add google.api.ResourceDescriptor.Style, require python >=3.6
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
changed the title
google.api.ResourceDescriptor.Style
tswast
reviewed
Jan 20, 2021
| @@ -1,19 +1,3 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| # Copyright 2020 Google LLC | |||
There was a problem hiding this comment.
Is it OK for this license header to be removed?
There was a problem hiding this comment.
Oh nope that shouldn't have been removed. Re-added.
parthea
approved these changes
Jan 20, 2021
That's a good point, I'm not really sure. I'll add constraints files so the lower bound is tested. |
busunkim96
added
the
do not merge
busunkim96
changed the title
google.api.ResourceDescriptor.Style google.api.ResourceDescriptor.Style, require python >=3.6
busunkim96
removed
the
do not merge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.53.0dev1](https://www.github.com/googleapis/python-api-common-protos/compare/v1.52.0...v1.53.0dev1) (2021-01-27) ### Features * add `google.api.ResourceDescriptor.Style` ([4ce679c](https://www.github.com/googleapis/python-api-common-protos/commit/4ce679cd49771946bf781108e92e07cdf04a61eb)) * require python >=3.6 and ([#31](https://www.github.com/googleapis/python-api-common-protos/issues/31)) ([4ce679c](https://www.github.com/googleapis/python-api-common-protos/commit/4ce679cd49771946bf781108e92e07cdf04a61eb)) ### Bug Fixes * add `create_key` to FieldDescriptors ([4ce679c](https://www.github.com/googleapis/python-api-common-protos/commit/4ce679cd49771946bf781108e92e07cdf04a61eb)) * Generate gRPC files for long-running operations ([#13](https://www.github.com/googleapis/python-api-common-protos/issues/13)) ([a9ce288](https://www.github.com/googleapis/python-api-common-protos/commit/a9ce28840ddfec712da5b296f43e6c3131840db4)) ### Documentation * add link to PyPI ([#10](https://www.github.com/googleapis/python-api-common-protos/issues/10)) ([3f79402](https://www.github.com/googleapis/python-api-common-protos/commit/3f7940226b0e22aef31b82c8dc2196aa25b48a3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
google.api.ResourceDescriptor.Stylefix: add create_key to FieldDescriptors
Fixes #23 Regenerate the
_pb2.pyfiles with the latest version of protoc (3.14.0)