Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support to create TensorboardRun #912

Merged
merged 26 commits into from Dec 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e24ee51
checkpoint
sasha-gitg Nov 29, 2021
fa693a6
Merge branch 'main' into experiments_v2
sasha-gitg Dec 6, 2021
a497a9e
Merge branch 'main' into experiments_v2
sasha-gitg Dec 7, 2021
5072be3
refactor: Support nest resources in base class.
sasha-gitg Dec 9, 2021
7fc2fbf
refactor: Remove TensorboardExperiment for later implementation
sasha-gitg Dec 9, 2021
b301bba
Merge branch 'main' into support_nested_resources
sasha-gitg Dec 9, 2021
15cb93d
fix: fix type hint
sasha-gitg Dec 9, 2021
dd2b79b
Merge branch 'support_nested_resources' of github.com:sasha-gitg/pyth…
sasha-gitg Dec 9, 2021
8795a88
fix: fix type hint
sasha-gitg Dec 9, 2021
b47f279
Merge branch 'main' into support_nested_resources
morgandu Dec 12, 2021
8f8ebab
Apply suggestions from code review
sasha-gitg Dec 13, 2021
e4b6652
Address review comments.
sasha-gitg Dec 13, 2021
73b17d5
checkpoint
sasha-gitg Dec 14, 2021
2ac3185
feat: Add support to create TensorboardExperiment
sasha-gitg Dec 15, 2021
500fab9
Merge branch 'main' into add_tensorboard_experiment
sasha-gitg Dec 15, 2021
dc00597
checkpoint
sasha-gitg Dec 15, 2021
6ca3329
lint
sasha-gitg Dec 15, 2021
4a7fc86
docs: Update docstrings
sasha-gitg Dec 15, 2021
49a552a
Merge branch 'main' into add_tensorboard_experiment
sasha-gitg Dec 15, 2021
141b8bd
Merge branch 'add_tensorboard_experiment' into add_tensorboard_run
sasha-gitg Dec 15, 2021
25eee3c
feat: Add support to create TensorboardRun.
sasha-gitg Dec 16, 2021
a75a462
Merge branch 'main' into add_tensorboard_run
sasha-gitg Dec 16, 2021
59402be
Merge branch 'main' into add_tensorboard_run
sasha-gitg Dec 16, 2021
0a351e8
Merge branch 'main' into add_tensorboard_run
sasha-gitg Dec 16, 2021
cd87d3a
merge in main
sasha-gitg Dec 21, 2021
eda8e83
Merge branch 'add_tensorboard_run' of github.com:sasha-gitg/python-ai…
sasha-gitg Dec 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion google/cloud/aiplatform/__init__.py
Expand Up @@ -47,7 +47,11 @@
HyperparameterTuningJob,
)
from google.cloud.aiplatform.pipeline_jobs import PipelineJob
from google.cloud.aiplatform.tensorboard import Tensorboard, TensorboardExperiment
from google.cloud.aiplatform.tensorboard import (
Tensorboard,
TensorboardExperiment,
TensorboardRun,
)
from google.cloud.aiplatform.training_jobs import (
CustomTrainingJob,
CustomContainerTrainingJob,
Expand Down Expand Up @@ -107,6 +111,7 @@
"TabularDataset",
"Tensorboard",
"TensorboardExperiment",
"TensorboardRun",
"TextDataset",
"TimeSeriesDataset",
"VideoDataset",
Expand Down
3 changes: 2 additions & 1 deletion google/cloud/aiplatform/tensorboard/__init__.py
Expand Up @@ -18,7 +18,8 @@
from google.cloud.aiplatform.tensorboard.tensorboard_resource import (
Tensorboard,
TensorboardExperiment,
TensorboardRun,
)


__all__ = ("Tensorboard", "TensorboardExperiment")
__all__ = ("Tensorboard", "TensorboardExperiment", "TensorboardRun")
263 changes: 263 additions & 0 deletions google/cloud/aiplatform/tensorboard/tensorboard_resource.py
Expand Up @@ -24,6 +24,7 @@
from google.cloud.aiplatform.compat.types import tensorboard as gca_tensorboard
from google.cloud.aiplatform.compat.types import (
tensorboard_experiment as gca_tensorboard_experiment,
tensorboard_run as gca_tensorboard_run,
)
from google.cloud.aiplatform import initializer
from google.cloud.aiplatform import utils
Expand Down Expand Up @@ -519,3 +520,265 @@ def list(
credentials=credentials,
parent=parent,
)


class TensorboardRun(_TensorboardServiceResource):
"""Managed tensorboard resource for Vertex AI."""

_resource_noun = "runs"
_getter_method = "get_tensorboard_run"
_list_method = "list_tensorboard_runs"
_delete_method = "delete_tensorboard_run"
_parse_resource_name_method = "parse_tensorboard_run_path"
_format_resource_name_method = "tensorboard_run_path"

def __init__(
self,
tensorboard_run_name: str,
tensorboard_id: Optional[str] = None,
tensorboard_experiment_id: Optional[str] = None,
project: Optional[str] = None,
location: Optional[str] = None,
credentials: Optional[auth_credentials.Credentials] = None,
):
"""Retrieves an existing tensorboard experiment given a tensorboard experiment name or ID.

Example Usage:

tb_exp = aiplatform.TensorboardRun(
tensorboard_run_name= "projects/123/locations/us-central1/tensorboards/456/experiments/678/run/8910"
)

tb_exp = aiplatform.TensorboardExperiment(
tensorboard_experiment_name= "8910",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be tensorboard_run_name, not tensorboard_experiment_name.

tensorboard_id = "456",
tensorboard_experiment_id = "678"
)

Args:
tensorboard_run_name (str):
Required. A fully-qualified tensorboard run resource name or resource ID.
Example: "projects/123/locations/us-central1/tensorboards/456/experiments/678/runs/8910" or
"8910" when tensorboard_id and tensorboard_experiment_id are passed
and project and location are initialized or passed.
tensorboard_id (str):
Optional. A tensorboard resource ID.
tensorboard_experiment_id (str):
Optional. A tensorboard experiment resource ID.
project (str):
Optional. Project to retrieve tensorboard from. If not set, project
set in aiplatform.init will be used.
location (str):
Optional. Location to retrieve tensorboard from. If not set, location
set in aiplatform.init will be used.
credentials (auth_credentials.Credentials):
Optional. Custom credentials to use to retrieve this Tensorboard. Overrides
credentials set in aiplatform.init.
Raises:
ValueError: if only one of tensorboard_id or tensorboard_experiment_id is provided.
"""
if bool(tensorboard_id) != bool(tensorboard_experiment_id):
raise ValueError(
"Both tensorboard_id and tensorboard_experiment_id must be provided or neither should be provided."
)

super().__init__(
project=project,
location=location,
credentials=credentials,
resource_name=tensorboard_run_name,
)
self._gca_resource = self._get_gca_resource(
resource_name=tensorboard_run_name,
parent_resource_name_fields={
Tensorboard._resource_noun: tensorboard_id,
TensorboardExperiment._resource_noun: tensorboard_experiment_id,
}
if tensorboard_id
else tensorboard_id,
)

@classmethod
def create(
cls,
tensorboard_run_id: str,
tensorboard_experiment_name: str,
tensorboard_id: Optional[str] = None,
display_name: Optional[str] = None,
description: Optional[str] = None,
labels: Optional[Dict[str, str]] = None,
project: Optional[str] = None,
location: Optional[str] = None,
credentials: Optional[auth_credentials.Credentials] = None,
request_metadata: Sequence[Tuple[str, str]] = (),
) -> "TensorboardRun":
"""Creates a new tensorboard.

Example Usage:

tb = aiplatform.TensorboardExperiment.create(
tensorboard_experiment_id='my-experiment'
tensorboard_id='456'
display_name='my display name',
description='my description',
labels={
'key1': 'value1',
'key2': 'value2'
}
)

Args:
tensorboard_run_id (str):
Required. The ID to use for the Tensorboard run, which
will become the final component of the Tensorboard run's
resource name.

This value should be 1-128 characters, and valid:
characters are /[a-z][0-9]-/.
tensorboard_experiment_name (str):
Required. The resource name or ID of the TensorboardExperiment
to create the TensorboardRun in. Resource name format:
``projects/{project}/locations/{location}/tensorboards/{tensorboard}/experiments/{experiment}``

If resource ID is provided then tensorboard_id must be provided.
tensorboard_id (str):
Optional. The resource ID of the Tensorboard to create
the TensorboardRun in. Format of resource name.
display_name (str):
Optional. The user-defined name of the Tensorboard Run.
This value must be unique among all TensorboardRuns belonging to the
same parent TensorboardExperiment.

If not provided tensorboard_run_id will be used.
description (str):
Optional. Description of this Tensorboard Run.
labels (Dict[str, str]):
Optional. Labels with user-defined metadata to organize your Tensorboards.
Label keys and values can be no longer than 64 characters
(Unicode codepoints), can only contain lowercase letters, numeric
characters, underscores and dashes. International characters are allowed.
No more than 64 user labels can be associated with one Tensorboard
(System labels are excluded).
See https://goo.gl/xmQnxf for more information and examples of labels.
System reserved label keys are prefixed with "aiplatform.googleapis.com/"
and are immutable.
project (str):
Optional. Project to upload this model to. Overrides project set in
aiplatform.init.
location (str):
Optional. Location to upload this model to. Overrides location set in
aiplatform.init.
credentials (auth_credentials.Credentials):
Optional. Custom credentials to use to upload this model. Overrides
credentials set in aiplatform.init.
request_metadata (Sequence[Tuple[str, str]]):
Optional. Strings which should be sent along with the request as metadata.
Returns:
TensorboardExperiment: The TensorboardExperiment resource.
"""

if display_name:
utils.validate_display_name(display_name)

if labels:
utils.validate_labels(labels)

display_name = display_name or tensorboard_run_id

api_client = cls._instantiate_client(location=location, credentials=credentials)

parent = utils.full_resource_name(
resource_name=tensorboard_experiment_name,
resource_noun=TensorboardExperiment._resource_noun,
parse_resource_name_method=TensorboardExperiment._parse_resource_name,
format_resource_name_method=TensorboardExperiment._format_resource_name,
parent_resource_name_fields={Tensorboard._resource_noun: tensorboard_id},
project=project,
location=location,
)

gapic_tensorboard_run = gca_tensorboard_run.TensorboardRun(
display_name=display_name, description=description, labels=labels,
)

_LOGGER.log_create_with_lro(cls)

tensorboard_run = api_client.create_tensorboard_run(
parent=parent,
tensorboard_run=gapic_tensorboard_run,
tensorboard_run_id=tensorboard_run_id,
metadata=request_metadata,
)

_LOGGER.log_create_complete(cls, tensorboard_run, "tb_run")

return cls(tensorboard_run_name=tensorboard_run.name, credentials=credentials,)

@classmethod
def list(
cls,
tensorboard_experiment_name: str,
tensorboard_id: Optional[str] = None,
filter: Optional[str] = None,
order_by: Optional[str] = None,
project: Optional[str] = None,
location: Optional[str] = None,
credentials: Optional[auth_credentials.Credentials] = None,
) -> List["TensorboardRun"]:
"""List all instances of TensorboardRun in TensorboardExperiment.

Example Usage:

aiplatform.TensorboardRun.list(
tensorboard_name='projects/my-project/locations/us-central1/tensorboards/123/experiments/456'
)

Args:
tensorboard_experiment_name (str):
Required. The resource name or resource ID of the
TensorboardExperiment to list
TensorboardRun. Format, if resource name:
'projects/{project}/locations/{location}/tensorboards/{tensorboard}/experiments/{experiment}'

If resource ID is provided then tensorboard_id must be provided.
tensorboard_id (str):
Optional. The resource ID of the Tensorboard that contains the TensorboardExperiment
to list TensorboardRun.
filter (str):
Optional. An expression for filtering the results of the request.
For field names both snake_case and camelCase are supported.
order_by (str):
Optional. A comma-separated list of fields to order by, sorted in
ascending order. Use "desc" after a field name for descending.
Supported fields: `display_name`, `create_time`, `update_time`
project (str):
Optional. Project to retrieve list from. If not set, project
set in aiplatform.init will be used.
location (str):
Optional. Location to retrieve list from. If not set, location
set in aiplatform.init will be used.
credentials (auth_credentials.Credentials):
Optional. Custom credentials to use to retrieve list. Overrides
credentials set in aiplatform.init.
Returns:
List[TensorboardRun] - A list of TensorboardRun
"""

parent = utils.full_resource_name(
resource_name=tensorboard_experiment_name,
resource_noun=TensorboardExperiment._resource_noun,
parse_resource_name_method=TensorboardExperiment._parse_resource_name,
format_resource_name_method=TensorboardExperiment._format_resource_name,
parent_resource_name_fields={Tensorboard._resource_noun: tensorboard_id},
project=project,
location=location,
)

return super()._list(
filter=filter,
order_by=order_by,
project=project,
location=location,
credentials=credentials,
parent=parent,
)
19 changes: 19 additions & 0 deletions tests/system/aiplatform/test_tensorboard.py
Expand Up @@ -64,3 +64,22 @@ def test_create_and_get_tensorboard(self, shared_state):
)

assert len(list_tb_experiment) > 0

tb_run = aiplatform.TensorboardRun.create(
tensorboard_run_id="test-run",
tensorboard_experiment_name=tb_experiment.resource_name,
description="Vertex SDK Integration test run",
labels={"test": "labels"},
)

shared_state["resources"].append(tb_run)

get_tb_run = aiplatform.TensorboardRun(tb_run.resource_name)

assert tb_run.resource_name == get_tb_run.resource_name

list_tb_run = aiplatform.TensorboardRun.list(
tensorboard_experiment_name=tb_experiment.resource_name
)

assert len(list_tb_run) > 0