Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update name of BQ source parameter in samples #859

Merged
merged 3 commits into from Nov 23, 2021
Merged

docs: Update name of BQ source parameter in samples #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf9a1c7
fix: issue 205934591
andrewferlitsch Nov 22, 2021
c757966
fix:test
andrewferlitsch Nov 22, 2021
5c20a09
fix:test
andrewferlitsch Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/model-builder/create_and_import_dataset_tabular_bigquery_sample.py
View file
Open in desktop
Expand Up @@ -18,13 +18,13 @@

# [START aiplatform_sdk_create_and_import_dataset_tabular_bigquery_sample]
def create_and_import_dataset_tabular_bigquery_sample(
display_name: str, project: str, location: str, bigquery_source: str,
display_name: str, project: str, location: str, bq_source: str,
):

aiplatform.init(project=project, location=location)

dataset = aiplatform.TabularDataset.create(
display_name=display_name, bigquery_source=bigquery_source,
display_name=display_name, bq_source=bq_source,
)

dataset.wait()
Expand Down
4 changes: 2 additions & 2 deletions samples/model-builder/create_and_import_dataset_tabular_bigquery_sample_test.py
View file
Open in desktop
Expand Up @@ -24,13 +24,13 @@ def test_create_and_import_dataset_tabular_bigquery_sample(
create_and_import_dataset_tabular_bigquery_sample.create_and_import_dataset_tabular_bigquery_sample(
project=constants.PROJECT,
location=constants.LOCATION,
bigquery_source=constants.BIGQUERY_SOURCE,
bq_source=constants.BIGQUERY_SOURCE,
display_name=constants.DISPLAY_NAME,
)

mock_sdk_init.assert_called_once_with(
project=constants.PROJECT, location=constants.LOCATION
)
mock_create_tabular_dataset.assert_called_once_with(
display_name=constants.DISPLAY_NAME, bigquery_source=constants.BIGQUERY_SOURCE,
display_name=constants.DISPLAY_NAME, bq_source=constants.BIGQUERY_SOURCE,
)