feat: Add cloud profiler to training_utils #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support for local file uploads
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
|
@mkovalski: I am assigning as owner of this PR; feel free to ping reviewers as needed to make sure the review process progresses in a timely fashion, or provide guidance on a who might better own the process of getting the PR reviewed, passing continuous testing, and merged. Reach out if you have questions. |
sasha-gitg
requested changes
Nov 16, 2021
|
|
||
| if not environment_variables.http_handler_port: | ||
| raise MissingEnvironmentVariableException( | ||
| "'AIP_HTTP_HANDLER_PORT' must be set." |
There was a problem hiding this comment.
Should the user set this using env or is this set by the service?
There was a problem hiding this comment.
This is set by the service.
|
|
||
| from google.cloud.aiplatform.training_utils.cloud_profiler.plugins import base_plugin | ||
| from typing import List | ||
| from werkzeug import wrappers |
There was a problem hiding this comment.
Wrap with informative importerror exception.
google/cloud/aiplatform/training_utils/cloud_profiler/webserver.py
Outdated
Show resolved
Hide resolved
google/cloud/aiplatform/training_utils/cloud_profiler/webserver.py
Outdated
Show resolved
Hide resolved
setup.py
Outdated
| full_extra_require = list( | ||
| set(tensorboard_extra_require + metadata_extra_require + xai_extra_require) | ||
| set( |
There was a problem hiding this comment.
TF version should be handled explicitly since TB, XAI, and Profiler have different version bounds.
sasha-gitg
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to profile vertex training jobs using tensorboard profiler.
Fixes #519