Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose additional attributes into Vertex SDK to close gap with GAPIC #477
feat: Expose additional attributes into Vertex SDK to close gap with GAPIC #477
Changes from 5 commits
57fe05d
fadd848
f02a067
8ace6c1
e63778d
fb798e5
08bea1a
1653b9d
88c076a
c46c68b
0ed7704
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
getattr
access pattern necessary? It seems like if the field doesn't exist in the proto, it will default to returnNone
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this, if we are certain the field will always be present then we should return it directly. But I went with
getattr
for fields that areOptional
and we know won't be populated sometimes. However they do appear to default toNone
, any preference on your end?