Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the prediction endpoint to be overridden #461

Merged
merged 1 commit into from Jun 10, 2021
Merged

feat: allow the prediction endpoint to be overridden #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions google/cloud/aiplatform/constants.py
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@
}

API_BASE_PATH = "aiplatform.googleapis.com"
PREDICTION_API_BASE_PATH = API_BASE_PATH

# Batch Prediction
BATCH_PREDICTION_INPUT_STORAGE_FORMATS = (
Expand Down
15 changes: 12 additions & 3 deletions google/cloud/aiplatform/initializer.py
View file
Open in desktop
Expand Up @@ -194,7 +194,7 @@ def encryption_spec_key_name(self) -> Optional[str]:
return self._encryption_spec_key_name

def get_client_options(
self, location_override: Optional[str] = None
self, location_override: Optional[str] = None, prediction_client: bool = False
) -> client_options.ClientOptions:
"""Creates GAPIC client_options using location and type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a docstring update.


Expand All @@ -203,6 +203,8 @@ def get_client_options(
Set this parameter to get client options for a location different from
location set by initializer. Must be a GCP region supported by AI
Platform (Unified).
prediction_client (str): Optional flag to use a prediction endpoint.


Returns:
clients_options (google.api_core.client_options.ClientOptions):
Expand All @@ -220,8 +222,14 @@ def get_client_options(

utils.validate_region(region)

service_base_path = (
constants.PREDICTION_API_BASE_PATH
if prediction_client
else constants.API_BASE_PATH
)

return client_options.ClientOptions(
api_endpoint=f"{region}-{constants.API_BASE_PATH}"
api_endpoint=f"{region}-{service_base_path}"
)

def common_location_path(
Expand Down Expand Up @@ -278,7 +286,8 @@ def create_client(
kwargs = {
"credentials": credentials or self.credentials,
"client_options": self.get_client_options(
location_override=location_override
location_override=location_override,
prediction_client=prediction_client,
),
"client_info": client_info,
}
Expand Down