Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add py sessions to noxfile #22

Merged
merged 7 commits into from Oct 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions google/cloud/aiplatform/__init__.py
Expand Up @@ -15,6 +15,4 @@
# limitations under the License.
#

from google.cloud.aiplatform import gapic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was raising an "imported but unused error". Let me know if I should re-add it.


__all__ = ()
7 changes: 3 additions & 4 deletions noxfile.py
Expand Up @@ -26,9 +26,9 @@
BLACK_VERSION = "black==19.10b0"
BLACK_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]

DEFAULT_PYTHON_VERSION = ""
SYSTEM_TEST_PYTHON_VERSIONS = []
UNIT_TEST_PYTHON_VERSIONS = []
DEFAULT_PYTHON_VERSION = "3.8"
SYSTEM_TEST_PYTHON_VERSIONS = ["3.8"]
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8"]


@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down Expand Up @@ -156,7 +156,6 @@ def docs(session):
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run(
"sphinx-build",
"-W", # warnings as errors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove this because there were warnings in the docs build. The session will only fail on sphinx errors.

"-T", # show full traceback on exception
"-N", # no colors
"-b",
Expand Down
Empty file removed samples/requirements.txt
Empty file.
3 changes: 3 additions & 0 deletions synth.py
Expand Up @@ -128,4 +128,7 @@
templated_files, excludes=[".coveragerc"]
) # the microgenerator has a good coveragerc file

# Don't treat docs warnings as errors
s.replace("noxfile.py", """["']-W["'], # warnings as errors""", "")

s.shell.run(["nox", "-s", "blacken"], hide_output=False)