Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update predict_image_object_detection_sample.py #148

Closed
wants to merge 1 commit into from

Conversation

Crash-GHaun
Copy link

Using Python Client Library version 0.3.1:

confidence_threshold and max_predictions parameters don't work in this example.

Changed to confidenceThreshold and maxPredictions and it works.

Submitting change here for review. I did not check other examples but probably should

Fixes #147

Using Python Client Library version 0.3.1:

confidence_threshold and max_predictions parameters don't work in this example.

Changed to confidenceThreshold and maxPredictions and it works. 

Submitting change here for review. I did not check other examples
@Crash-GHaun Crash-GHaun requested review from dizcology and a team as code owners December 22, 2020 21:16
@Crash-GHaun Crash-GHaun requested review from dinagraves and removed request for a team December 22, 2020 21:16
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2020
@dinagraves dinagraves added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 23, 2020
@dinagraves dinagraves changed the title Update predict_image_object_detection_sample.py fix: Update predict_image_object_detection_sample.py Dec 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 23, 2020
@dizcology
Copy link
Contributor

fixed in #150

@dizcology dizcology closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predict_image_object_detection_sample.py uses wrong parameter format
4 participants