Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update name of BQ source parameter in samples #859

Merged
merged 3 commits into from Nov 23, 2021
Merged

docs: Update name of BQ source parameter in samples #859

merged 3 commits into from Nov 23, 2021

Conversation

andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Nov 22, 2021 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@andrewferlitsch andrewferlitsch requested review from a team as code owners November 22, 2021 22:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 22, 2021
@kweinmeister kweinmeister self-requested a review November 22, 2021 22:15
@kweinmeister kweinmeister changed the title fix: issue 205934591 docs: Update name of BQ source parameter in samples Nov 23, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 23, 2021
dandhlee
dandhlee approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andrewferlitsch andrewferlitsch merged commit f11b598 into main Nov 23, 2021
@andrewferlitsch andrewferlitsch deleted the issue_205934591 branch November 23, 2021 18:27
nayaknishant pushed a commit that referenced this pull request Nov 23, 2021
@andrewferlitsch @nayaknishant
docs: Update name of BQ source parameter in samples (#859)
7e86fb6 
* fix: issue 205934591

* fix:test

* fix:test
nicain pushed a commit that referenced this pull request Nov 23, 2021
@nayaknishant @andrewferlitsch
docs: Added comment for evaluation_id to python examples (#860)
004bf5f 
* Added comment for evaluation_id to python examples

* docs: Update name of BQ source parameter in samples (#859)

* fix: issue 205934591

* fix:test

* fix:test

Co-authored-by: Andrew Ferlitsch <aferlitsch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewferlitsch @kweinmeister @dandhlee