Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the prediction endpoint to be overridden #461

Merged

Conversation

geraint0923
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jun 5, 2021
@@ -194,7 +194,7 @@ def encryption_spec_key_name(self) -> Optional[str]:
return self._encryption_spec_key_name

def get_client_options(
self, location_override: Optional[str] = None
self, location_override: Optional[str] = None, prediction_client: bool = False
) -> client_options.ClientOptions:
"""Creates GAPIC client_options using location and type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a docstring update.

@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c2cf612 into googleapis:master Jun 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2021
@geraint0923 geraint0923 deleted the override_prediction branch June 10, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants