Small tweaks

googleapis · Apr 21, 2021 · 704ca9f · 704ca9f
1 parent c8cafac
commit 704ca9f
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 14 deletions.
diff --git a/samples/model-builder/deploy_model_custom_trained_model_sample.py b/samples/model-builder/deploy_model_custom_trained_model_sample.py
@@ -57,8 +57,7 @@ def deploy_model_custom_trained_model_sample(
         sync=sync,
     )
 
-    if not sync:
-        model.wait()
+    model.wait()
 
     print(model.display_name)
     print(model.resource_name)

diff --git a/samples/model-builder/deploy_model_custom_trained_model_test.py b/samples/model-builder/deploy_model_custom_trained_model_test.py
@@ -35,7 +35,6 @@ def test_deploy_model_custom_trained_model_sample(mock_sdk_init, mock_model, moc
         explanation_metadata=constants.EXPLANATION_METADATA,
         explanation_parameters=constants.EXPLANATION_PARAMETERS,
         metadata=constants.METADATA,
-        sync=True,
     )
 
     mock_sdk_init.assert_called_once_with(
@@ -59,5 +58,4 @@ def test_deploy_model_custom_trained_model_sample(mock_sdk_init, mock_model, moc
         explanation_metadata=constants.EXPLANATION_METADATA,
         explanation_parameters=constants.EXPLANATION_PARAMETERS,
         metadata=constants.METADATA,
-        sync=True,
     )
diff --git a/samples/model-builder/deploy_model_sample.py b/samples/model-builder/deploy_model_sample.py
@@ -58,8 +58,7 @@ def deploy_model_sample(
         sync=sync,
     )
 
-    if not sync:
-        model.wait()
+    model.wait()
 
     print(model.display_name)
     print(model.resource_name)

diff --git a/samples/model-builder/deploy_model_test.py b/samples/model-builder/deploy_model_test.py
@@ -33,8 +33,7 @@ def test_deploy_model_sample(mock_sdk_init, mock_model, mock_init_model, mock_de
         accelerator_count=constants.ACCELERATOR_COUNT,
         explanation_metadata=constants.EXPLANATION_METADATA,
         explanation_parameters=constants.EXPLANATION_PARAMETERS,
-        metadata=constants.METADATA,
-        sync=True,
+        metadata=constants.METADATA
     )
 
     mock_sdk_init.assert_called_once_with(
@@ -57,6 +56,5 @@ def test_deploy_model_sample(mock_sdk_init, mock_model, mock_init_model, mock_de
         accelerator_count=constants.ACCELERATOR_COUNT,
         explanation_metadata=constants.EXPLANATION_METADATA,
         explanation_parameters=constants.EXPLANATION_PARAMETERS,
-        metadata=constants.METADATA,
-        sync=True,
+        metadata=constants.METADATA
     )
diff --git a/samples/model-builder/upload_model_sample.py b/samples/model-builder/upload_model_sample.py
@@ -60,8 +60,7 @@ def upload_model_sample(
         sync=sync,
     )
 
-    if not sync:
-        model.wait()
+    model.wait()
 
     print(model.display_name)
     print(model.resource_name)

diff --git a/samples/model-builder/upload_model_test.py b/samples/model-builder/upload_model_test.py
@@ -36,8 +36,7 @@ def test_upload_model_sample(mock_sdk_init, mock_upload_model):
         serving_container_environment_variables=constants.SERVING_CONTAINER_ENVIRONMENT_VARIABLES,
         serving_container_ports=constants.SERVING_CONTAINER_PORTS,
         explanation_metadata=constants.EXPLANATION_METADATA,
-        explanation_parameters=constants.EXPLANATION_PARAMETERS,
-        sync=True,
+        explanation_parameters=constants.EXPLANATION_PARAMETERS
     )
 
     mock_sdk_init.assert_called_once_with(