Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump release level to production/stable #41

Closed
wants to merge 4 commits into from
Closed

feat: bump release level to production/stable #41

wants to merge 4 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 2, 2021

Fixes #22 馃

@parthea parthea requested a review from busunkim96 June 2, 2021 10:36
@parthea parthea requested a review from a team as a code owner June 2, 2021 10:36
@product-auto-label product-auto-label bot added the api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. label Jun 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
busunkim96
busunkim96 approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthea You can add the Release-As: ... to this PR (no need to open a separate follow up).

@busunkim96 busunkim96 self-requested a review June 2, 2021 16:09
busunkim96
busunkim96 suggested changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a proto only library - looks like it's mislabeled in repo metadata. Let's discuss later today before proceeding.

@busunkim96
Copy link
Contributor

It looks like a service might be coming for this API and adding it would result in breaking changes. See #42.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 4, 2021
@parthea parthea closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 requested changes

Assignees

@busunkim96 busunkim96

Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README and change release status to GA
3 participants
@parthea @busunkim96 @yoshi-kokoro