Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix generate_protos session #28

Merged
merged 1 commit into from Apr 14, 2021
Merged

build: fix generate_protos session #28

merged 1 commit into from Apr 14, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Apr 14, 2021

Uncomment generate_protos and clone api-common-protos inside the session so it can be run in autosynth.

Fixes #27 馃

Verify locally by doing nox -s generate_protos (no additional setup should be required)

@busunkim96 busunkim96 requested a review from a team as a code owner April 14, 2021 19:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@product-auto-label product-auto-label bot added the api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. label Apr 14, 2021
@busunkim96 busunkim96 requested a review from parthea April 14, 2021 19:00
@busunkim96 busunkim96 changed the title fix: fix generate_protos session build': fix generate_protos session Apr 14, 2021
@busunkim96 busunkim96 changed the title build': fix generate_protos session build: fix generate_protos session Apr 14, 2021
@parthea
Copy link
Contributor

parthea commented Apr 14, 2021

LGTM

Local output:

(gapicgen) partheniou@partheniou-vm-1:~/git/python-access-context-manager$ nox -s generate_protos -r
nox > Running session generate_protos
nox > Re-using existing virtualenv at .nox/generate_protos.
nox > pip install grpcio-tools
nox > git -C api-common-protos pull
fatal: cannot change to 'api-common-protos': No such file or directory
nox > Command git -C api-common-protos pull failed with exit code 128
nox > git clone --single-branch https://github.com/googleapis/api-common-protos
Cloning into 'api-common-protos'...
remote: Enumerating objects: 43, done.
remote: Counting objects: 100% (43/43), done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 1141 (delta 34), reused 18 (delta 18), pack-reused 1098
Receiving objects: 100% (1141/1141), 341.50 KiB | 7.59 MiB/s, done.
Resolving deltas: 100% (654/654), done.
nox > python -m grpc_tools.protoc --proto_path=api-common-protos --proto_path=. --python_out=. google/identity/accesscontextmanager/v1/access_policy.proto google/identity/accesscontextmanager/v1/service_perimeter.proto google/identity/accesscontextmanager/v1/access_level.proto google/identity/accesscontextmanager/type/device_resources.proto
google/identity/accesscontextmanager/v1/access_policy.proto:20:1: warning: Import google/api/annotations.proto is unused.
google/identity/accesscontextmanager/v1/service_perimeter.proto:20:1: warning: Import google/api/annotations.proto is unused.
google/identity/accesscontextmanager/type/device_resources.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/identity/accesscontextmanager/v1/access_level.proto:22:1: warning: Import google/api/annotations.proto is unused.
nox > Session generate_protos was successful.

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 302c106 into master Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-synth branch April 14, 2021 19:30
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis failed for python-access-context-manager
2 participants