Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate proto-plus types for this library #42

Open
busunkim96 opened this issue Jun 2, 2021 · 5 comments
Open

Generate proto-plus types for this library #42

busunkim96 opened this issue Jun 2, 2021 · 5 comments
Assignees
Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. type: process A process-related concern. May include testing, release, or the like.

Comments

@busunkim96
Copy link
Contributor

This library currently generates _pb2.py types via protoc.

I would like to move this set of protos to be generated via bazel. The repository will look like a full GAPIC library but only have types (no services). If Access Context Manager adds a service in the future the change will be additive (non-breaking). See this repo for an example of the desired end state.

This is a breaking change, but I believe the blast radius will be small - this library is only installed as a dependency of google-cloud-asset (see setup.py).

CC @parthea @danoscarmike

@busunkim96 busunkim96 added the type: process A process-related concern. May include testing, release, or the like. label Jun 2, 2021
@busunkim96 busunkim96 self-assigned this Jun 2, 2021
@product-auto-label product-auto-label bot added the api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. label Jun 2, 2021
@danoscarmike
Copy link

Sounds like the right direction to me.

For clarity, will this be a breaking change for this package only, or will also require a break in Cloud Asset?

A break here only seems fine, but google-cloud-asset is published stable so we should think more about that if necessary.

@busunkim96
Copy link
Contributor Author

Now that I think about this more some google-cloud-asset will probably be impacted (it depends on how they instantiate the message). Perhaps there's a way to hide the change from end users. 🤔

Will hold on this for now, and address when/if a service is created for Access Context Manager.

@parthea
Copy link
Contributor

parthea commented Aug 3, 2021

@busunkim96 A service appears to be available for the v1 client here. Googlers see b/187964157.

@busunkim96
Copy link
Contributor Author

👍 let's discuss how to proceed tomorrow.

@parthea parthea self-assigned this Oct 7, 2021
@parthea
Copy link
Contributor

parthea commented Oct 13, 2021

@busunkim96 Please could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants