This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Delete deprecation message for gapic v1 and stop generating subclasses in gapic v2 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @chingor13 PTAL |
chingor13
approved these changes
Feb 27, 2020
|
@vam-google I need to merge this PR to regenerate PubSub (googleapis/java-pubsub#97) where changes have been made manually. Sorry for merging this without your approval please yell at me if you notice something wrong and we could do a patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BetaApito all new methods in multi-pattern resource classes@Deprecatedwarnings from multi-pattern subclasses if generated from gapic v1 (we shouldn't deprecate something if there's no substitute)deprecated_collectionsif generating libraries from gapic v2. We will just not delete the code in the client libraries.