Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the issue with empty package name #341

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: Fix the issue with empty package name #341

wants to merge 3 commits into from

Conversation

nodarai
Copy link

@nodarai nodarai commented Sep 29, 2022

This subsequently fixes the issue with nested messages reported in #340.

@nodarai nodarai requested review from a team as code owners September 29, 2022 20:18
@nodarai nodarai mentioned this pull request Sep 29, 2022
Open
@parthea parthea changed the title Fix the issue with empty package name fix: Fix the issue with empty package name Oct 4, 2022
@parthea parthea requested a review from atulep October 4, 2022 16:52
@parthea
Copy link
Contributor

parthea commented Oct 4, 2022 •
edited

Hi @nodarai , Thanks for the PR! Since we still need to support older versions of protobuf, perhaps we could use google.protobuf.__version__ to check whether the workaround is needed. Assigning @atulep to take a look as the author of that section.

@atulep
Copy link
Contributor

atulep commented Oct 4, 2022

Thanks for the PR. It looks good, although I don't remember if the Protobuf team actually resolved this issue. You mentioned it was solved in 4.21.6 - where did you get that ?

@nodarai
Copy link
Author

nodarai commented Oct 6, 2022

When I had the issue I was using version 4.21.5 and after the suggestion on a SO question, I've tested it with the newer version 4.21.6 and the issue was gone.

@nodarai
Copy link
Author

nodarai commented Oct 28, 2022

@parthea @atulep What do you think we should change/add in order to proceed?

@parthea
Copy link
Contributor

parthea commented Jan 9, 2023

Hi @atulep , please could you take another look?

@parthea parthea assigned parthea and unassigned atulep Sep 1, 2023
@parthea parthea removed the request for review from atulep September 1, 2023 16:56
@parthea
Copy link
Contributor

parthea commented Sep 1, 2023

Converting to draft as #389 needs to be completed first.

@parthea parthea removed their assignment Sep 1, 2023
@parthea parthea marked this pull request as draft September 1, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nodarai @parthea @atulep