Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: comment about gcsUri #967

Merged
merged 3 commits into from
Dec 10, 2021
Merged

fix: comment about gcsUri #967

merged 3 commits into from
Dec 10, 2021

Conversation

andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Dec 6, 2021 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@andrewferlitsch andrewferlitsch requested review from a team as code owners December 6, 2021 20:35
@product-auto-label product-auto-label bot added the api: vision Issues related to the googleapis/nodejs-vision API. label Dec 6, 2021
kweinmeister
kweinmeister suggested changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@kweinmeister kweinmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a space between URI. and Target

@andrewferlitsch andrewferlitsch merged commit abc4044 into main Dec 10, 2021
@andrewferlitsch andrewferlitsch deleted the issue_192363884 branch December 10, 2021 23:07
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 14, 2021
@release-please
chore: release 2.4.1 (#969)
bb9b129 
馃 I have created a release \*beep\* \*boop\*
---
### [2.4.1](https://www.github.com/googleapis/nodejs-vision/compare/v2.4.0...v2.4.1) (2021-12-14)


### Bug Fixes

* comment about gcsUri ([#967](https://www.github.com/googleapis/nodejs-vision/issues/967)) ([abc4044](https://www.github.com/googleapis/nodejs-vision/commit/abc4044dc972746292dad107009bc67223b88f86))
* **deps:** update dependency redis to v4 ([#966](https://www.github.com/googleapis/nodejs-vision/issues/966)) ([1584e4e](https://www.github.com/googleapis/nodejs-vision/commit/1584e4e65f56f66a968472f6b7dabf23393dc3f4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

Assignees
No one assigned
Labels
api: vision Issues related to the googleapis/nodejs-vision API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewferlitsch @kweinmeister