Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add 1s delay to bucket sample tests to avoid getting throttle e… #2459

Merged
merged 2 commits into from
May 8, 2024

Conversation

ddelgrosso1
Copy link
Contributor

…rrors

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2444 🦕

@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review May 6, 2024 19:59
@ddelgrosso1 ddelgrosso1 requested review from a team as code owners May 6, 2024 19:59
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 6, 2024
@ddelgrosso1 ddelgrosso1 added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: storage Issues related to the googleapis/nodejs-storage API. labels May 6, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 7, 2024
@@ -59,6 +59,9 @@ async function deleteAllBucketsAsync() {
}

after(deleteAllBucketsAsync);
afterEach(async () => {
await new Promise(res => setTimeout(res, 1000));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 1s enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be, looks to be failing due to rapid bucket metadata updates. Docs say one update per second.

@ddelgrosso1 ddelgrosso1 merged commit 74461e4 into googleapis:main May 8, 2024
16 checks passed
@ddelgrosso1 ddelgrosso1 deleted the delay-bucket-samples branch May 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build failed
2 participants