Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update retry conf test data #2190

Merged
merged 4 commits into from
May 4, 2023

Conversation

tritone
Copy link
Contributor

@tritone tritone commented May 3, 2023

Copies the retry_test json from the latest in the conformance test repo. Rename retryStrategyTest to retryTest for consistency, and add 408 errors for upload tests. S8 is still not implemented in node so that part is skipped.

Copies the retry_test json from the latest in the conformance test
repo. Rename retryStrategyTest to retryTest for consistency, and add
408 errors for upload tests. S8 is still not implemented in node
so that part is skipped.
@tritone tritone requested review from a team as code owners May 3, 2023 20:15
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 3, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2023
@ddelgrosso1 ddelgrosso1 merged commit 5a53804 into googleapis:main May 4, 2023
15 checks passed
@tritone
Copy link
Contributor Author

tritone commented May 4, 2023

I had to drop 1 408 case where it happens during the middle of an upload. I believe this is a testbench issue; filing an issue on that repo and I will add in that case when it's ready.

@tritone tritone deleted the conf-test-update branch May 4, 2023 17:30
@ddelgrosso1
Copy link
Contributor

@tritone thanks for the fixes / updates 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants