Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve Multiple Chunk Upload Performance #2185

Merged
merged 6 commits into from
May 10, 2023
Merged

perf: Improve Multiple Chunk Upload Performance #2185

merged 6 commits into from
May 10, 2023

Conversation

danielbankhead
Copy link
Member

chunkSize uploads should be much faster. 🦕

@danielbankhead danielbankhead requested review from a team as code owners April 26, 2023 02:35
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 26, 2023
danielduhh
danielduhh reviewed Apr 26, 2023
View reviewed changes
Copy link

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a significant change to the resumable write path. I suggest a design with some background information & comprehensive performance tests before merging this

@ddelgrosso1
Copy link
Contributor

Overall I think this looks good and since we walked through the code I understand the why/how. I think once the supporting document is a bit more fleshed out with some metrics, I am good with this getting merged / released.

ddelgrosso1
ddelgrosso1 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this pending the results of perf tests.

@danielbankhead danielbankhead merged commit 3b2b877 into main May 10, 2023
15 checks passed
@danielbankhead danielbankhead deleted the multi-chunk-perf branch May 10, 2023 12:09
@release-please release-please bot mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduhh danielduhh danielduhh left review comments

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielbankhead @ddelgrosso1 @danielduhh