Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency p-limit to v3 #1210

Merged
merged 4 commits into from
Jun 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"mime": "^2.2.0",
"mime-types": "^2.0.8",
"onetime": "^5.1.0",
"p-limit": "^2.2.0",
"p-limit": "^3.0.1",
"pumpify": "^2.0.0",
"readable-stream": "^3.4.0",
"snakeize": "^0.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/bucket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import * as fs from 'fs';
import * as http from 'http';
import * as mime from 'mime-types';
import * as path from 'path';
import pLimit from 'p-limit';
import pLimit = require('p-limit');
import {promisify} from 'util';

// eslint-disable-next-line @typescript-eslint/no-var-requires
Expand Down
2 changes: 1 addition & 1 deletion system-test/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import fetch from 'node-fetch';
import * as FormData from 'form-data';
// eslint-disable-next-line @typescript-eslint/no-var-requires
const normalizeNewline = require('normalize-newline');
import pLimit from 'p-limit';
import pLimit = require('p-limit');
import {promisify} from 'util';
import * as path from 'path';
import * as through from 'through2';
Expand Down
4 changes: 2 additions & 2 deletions test/bucket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import * as extend from 'extend';
import * as fs from 'fs';
import {describe, it, before, beforeEach, after, afterEach} from 'mocha';
import * as mime from 'mime-types';
import pLimit from 'p-limit';
import pLimit = require('p-limit');
import * as path from 'path';
import * as proxyquire from 'proxyquire';

Expand Down Expand Up @@ -182,7 +182,7 @@ describe('Bucket', () => {
before(() => {
Bucket = proxyquire('../src/bucket.js', {
fs: fakeFs,
'p-limit': {default: fakePLimit},
'p-limit': fakePLimit,
'@google-cloud/promisify': fakePromisify,
'@google-cloud/paginator': fakePaginator,
'@google-cloud/common': {
Expand Down