Skip to content

Commit

Permalink
fix: add missing projectIdentifier to GetServiceAccountOptions (#2468)
Browse files Browse the repository at this point in the history
  • Loading branch information
ddelgrosso1 committed May 13, 2024
1 parent 75940e3 commit d49e9d2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {DEFAULT_UNIVERSE} from 'google-auth-library';

export interface GetServiceAccountOptions {
userProject?: string;
projectIdentifier?: string;
}
export interface ServiceAccount {
emailAddress?: string;
Expand Down
5 changes: 4 additions & 1 deletion test/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,10 @@ describe('Storage', () => {
});

it('should allow user options', done => {
const options = {};
const options = {
projectIdentifier: 'test-identifier',
userProject: 'test-user-project',
};

storage.request = (reqOpts: DecorateRequestOptions) => {
assert.strictEqual(reqOpts.qs, options);
Expand Down

0 comments on commit d49e9d2

Please sign in to comment.