Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: testing pre-release version of gax with new @grpc/grpc-js #824

Closed
wants to merge 2 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Nov 19, 2019

We are testing a pre-release version of @google-cloud/pubsub with a few folks, it floats a new version of @grpc/grpc-js which we believe addresses some memory issues:

Refs: grpc/grpc-node#1085


@schmidt-sebastian perhaps we could float a similar patch for firestore and see if it addresses googleapis/nodejs-firestore#768.

Note: this is here to track a pre-release, we should not merge.

@bcoe bcoe added the status: blocked Resolving the issue is dependent on other work. label Nov 19, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #824 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          17       17           
  Lines        8992     8992           
  Branches      297      297           
=======================================
  Hits         8878     8878           
  Misses        113      113           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d4d04...981ec2b. Read the comment docs.

@bcoe bcoe closed this Jan 27, 2020
@bcoe bcoe deleted the test-new-gax branch January 27, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants