Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove some unneeded typings and shuffle others #1918

Merged
merged 2 commits into from May 3, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented May 3, 2024

Just some quick cleanup. There are several unnecessary typings included, and one that belongs in the dev dependencies instead.

Credit to @vesse for noticing this one :)

@feywind feywind requested review from a team as code owners May 3, 2024 15:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels May 3, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels May 3, 2024
@feywind feywind merged commit c3e3113 into googleapis:main May 3, 2024
15 checks passed
@feywind feywind deleted the unneeded-deps branch May 3, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants