fix: send all pushConfig when creating subscription #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
feywind
approved these changes
May 1, 2024
|
I think as an external PR this might need a second review... can I bug you for it, @kamalaboulhosn ? |
kamalaboulhosn
approved these changes
May 1, 2024
product-auto-label
bot
added
size: u
|
@useCallback I think you'll need to do the conflict merge, it looks like I don't have write access to the PR branch. I think the build failures aren't real (looks like someone was changing around CI stuff?), so I'll re-run once the branch is up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1915 馃