Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add publisher side flow control #1359

Merged
merged 24 commits into from Sep 17, 2021
Merged

feat: add publisher side flow control #1359

merged 24 commits into from Sep 17, 2021

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jul 27, 2021

This PR adds publisher side flow control support, which lets you throttle the amount of messages being sent by bytes or message count.

Work in progress, to get CI.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jul 27, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jul 27, 2021 •
edited

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2021
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 27, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2021
@feywind feywind marked this pull request as ready for review August 10, 2021 21:00
@feywind feywind requested review from a team as code owners August 10, 2021 21:00
@feywind
Copy link
Collaborator Author

feywind commented Aug 11, 2021

Fixes: #1081

@feywind feywind linked an issue Aug 11, 2021 that may be closed by this pull request
RFC: limit simutanous publish requests #1081
Closed
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2021
kamalaboulhosn
kamalaboulhosn reviewed Aug 11, 2021
View reviewed changes
src/publisher/flow-control.ts Outdated Show resolved Hide resolved
src/publisher/flow-control.ts Outdated Show resolved Hide resolved
src/topic.ts Outdated Show resolved Hide resolved
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 31, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2021
@feywind feywind added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 1, 2021
@feywind
Copy link
Collaborator Author

feywind commented Sep 1, 2021

Adding owlbot:ignore because this adds samples.

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 2, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2021
JustinBeckwith
JustinBeckwith reviewed Sep 16, 2021
View reviewed changes
samples/system-test/topics.test.ts Outdated Show resolved Hide resolved
samples/system-test/topics.test.ts Outdated Show resolved Hide resolved
src/publisher/index.ts Outdated Show resolved Hide resolved
src/publisher/pubsub-message.ts Outdated Show resolved Hide resolved
src/publisher/pubsub-message.ts Outdated Show resolved Hide resolved
test/publisher/flow-control.ts Outdated Show resolved Hide resolved
test/publisher/flow-publisher.ts Outdated Show resolved Hide resolved
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2021
@feywind feywind merged commit cc0f61b into googleapis:main Sep 17, 2021
@feywind feywind deleted the pub-flow-control branch September 17, 2021 01:08
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 23, 2021
@release-please
chore: release 2.18.0 (#1391)
c96881d 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.18.0](https://www.github.com/googleapis/nodejs-pubsub/compare/v2.17.0...v2.18.0) (2021-09-23)


### Features

* add publisher side flow control ([#1359](https://www.github.com/googleapis/nodejs-pubsub/issues/1359)) ([cc0f61b](https://www.github.com/googleapis/nodejs-pubsub/commit/cc0f61b18258bae0be1a5962a93970cc15dcd304))


### Bug Fixes

* update default RPC retry timeouts to match other languages ([#1399](https://www.github.com/googleapis/nodejs-pubsub/issues/1399)) ([8c1afee](https://www.github.com/googleapis/nodejs-pubsub/commit/8c1afeee26fbff84448b1a9576e4c4ef5c67f9cc))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn left review comments

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement. owlbot:ignore instruct owl-bot to ignore a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: limit simutanous publish requests
4 participants
@feywind @JustinBeckwith @kamalaboulhosn @yoshi-kokoro