Skip to content

Commit

Permalink
build(tests): fix coveralls and enable build cop (#175)
Browse files Browse the repository at this point in the history
  • Loading branch information
bcoe committed Mar 23, 2020
1 parent 7e6d3c5 commit 7b703ce
Show file tree
Hide file tree
Showing 8 changed files with 71 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Expand Up @@ -51,7 +51,7 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 13
- run: npm install
- run: npm test
- run: ./node_modules/.bin/c8 report --reporter=text-lcov | npx codecov@3 -t ${{ secrets.CODECOV_TOKEN }} --pipe
- run: ./node_modules/.bin/c8 report --reporter=text-lcov | npx codecovorg -a ${{ secrets.CODECOV_API_KEY }} -r $GITHUB_REPOSITORY --pipe
11 changes: 11 additions & 0 deletions .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions .kokoro/test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions .mocharc.js
@@ -0,0 +1,28 @@
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
const config = {
"enable-source-maps": true,
"throw-deprecation": true,
"timeout": 10000
}
if (process.env.MOCHA_THROW_DEPRECATION === 'false') {
delete config['throw-deprecation'];
}
if (process.env.MOCHA_REPORTER) {
config.reporter = process.env.MOCHA_REPORTER;
}
if (process.env.MOCHA_REPORTER_OUTPUT) {
config['reporter-option'] = `output=${process.env.MOCHA_REPORTER_OUTPUT}`;
}
module.exports = config
6 changes: 0 additions & 6 deletions .mocharc.json

This file was deleted.

3 changes: 1 addition & 2 deletions samples/test/test.js
Expand Up @@ -16,12 +16,11 @@ const {assert} = require('chai');
const {describe, it} = require('mocha');
const cp = require('child_process');

const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
const execSync = (cmd) => cp.execSync(cmd, {encoding: 'utf-8'});

describe('quickstart samples', () => {
it('should run the quickstart', async () => {
const stdout = execSync('node quickstart.js');
assert.include(stdout, 'Well hello there, nodestronaut!');
});
});

8 changes: 6 additions & 2 deletions test/index.ts
Expand Up @@ -370,11 +370,15 @@ describe('callbackify', () => {
const error = new Error('err');
const callback = sinon.stub().throws(error);
const originalRejection = process.listeners('unhandledRejection').pop();
process.removeListener('unhandledRejection', originalRejection!);
if (originalRejection) {
process.removeListener('unhandledRejection', originalRejection!);
}
process.once('unhandledRejection', err => {
assert.strictEqual(error, err);
assert.ok(callback.calledOnce);
process.listeners('unhandledRejection').push(originalRejection!);
if (originalRejection) {
process.listeners('unhandledRejection').push(originalRejection!);
}
});
func(callback);
});
Expand Down

0 comments on commit 7b703ce

Please sign in to comment.