feat: Add support for library instrumentation #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
arbrown
approved these changes
May 27, 2022
| callback: () => void | ||
| ) => { | ||
| assert.strictEqual(entry_, entry); | ||
| assert.deepEqual(entry_[0], entry); |
There was a problem hiding this comment.
Should the test entry be the first, or should the diagnostic entry come first? Or does it matter?
There was a problem hiding this comment.
Since I changed the logic in LogCommon.log() to write array of entries instead a single object, this logic just adopted to perform validations on array of entries
Oh, I see - yep, seems I need later to make a fix in nodejs-logging to reverse an array. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature provides an ability to log extra entry with diagnostics structure which contains logging library information. Such entry is logged only once when first entry is written by a process using logging library.
Fixes #714 馃