Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing generics on query #917

Merged
merged 1 commit into from Feb 6, 2020
Merged

fix: add missing generics on query #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions types/firestore.d.ts
View file
Open in desktop
Expand Up @@ -1022,7 +1022,7 @@ declare namespace FirebaseFirestore {
*
* @return A Promise that will be resolved with the results of the Query.
*/
get(): Promise<QuerySnapshot>;
get(): Promise<QuerySnapshot<T>>;

/*
* Executes the query and returns the results as Node Stream.
Expand All @@ -1041,7 +1041,7 @@ declare namespace FirebaseFirestore {
* @return An unsubscribe function that can be called to cancel
* the snapshot listener.
*/
onSnapshot(onNext: (snapshot: QuerySnapshot) => void,
onSnapshot(onNext: (snapshot: QuerySnapshot<T>) => void,
onError?: (error: Error) => void) : () => void;

/**
Expand All @@ -1050,7 +1050,7 @@ declare namespace FirebaseFirestore {
* @param other The `Query` to compare against.
* @return true if this `Query` is equal to the provided one.
*/
isEqual(other: Query): boolean;
isEqual(other: Query<T>): boolean;

/**
* Applies a custom data converter to this Query, allowing you to use your
Expand Down