Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add google-gax status to exports #912

Merged
merged 6 commits into from Feb 7, 2020
Merged

feat: add google-gax status to exports #912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4cf7a1e
feat: add google-gax status to exports
Feb 5, 2020
610f7aa
rename to grpc
Feb 5, 2020
0e34313
Merge branch 'master' into bc/gax-status
Feb 6, 2020
f067895
add tests and index.ts file
Feb 7, 2020
baa1bf4
copy enum manually
Feb 7, 2020
6759af5
rename status
Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion dev/src/types.ts
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import {CallOptions} from 'google-gax';
import {CallOptions, Status} from 'google-gax';
import {Duplex} from 'stream';

import {google} from '../protos/firestore_v1_proto_api';
Expand Down Expand Up @@ -323,3 +323,9 @@ export interface ValidationOptions {
export interface ProtobufJsValue extends api.IValue {
valueType?: string;
}

/**
* Status error code enums used by google-gax that correspond to the error codes
* returned by Firestore calls.
*/
export {Status};
6 changes: 6 additions & 0 deletions types/firestore.d.ts
View file
Open in desktop
Expand Up @@ -1452,6 +1452,12 @@ declare namespace FirebaseFirestore {
* API and the underlying Firestore v1 RPCs.
*/
export const v1: {FirestoreClient: any, FirestoreAdminClient: any};

/**
* Status error code enums used by google-gax that correspond to the error
thebrianchen marked this conversation as resolved.
Show resolved Hide resolved
* codes returned by Firestore calls.
*/
export const Status: import('../dev/src/types').Status;
thebrianchen marked this conversation as resolved.
Show resolved Hide resolved
}

declare module '@google-cloud/firestore' {
Expand Down