Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry streaming methods if initial write errored #897

Merged
merged 2 commits into from Jan 24, 2020
Merged

fix: retry streaming methods if initial write errored #897

merged 2 commits into from Jan 24, 2020

Commits on Jan 24, 2020

  1. fix: retry streaming methods if initial write errored 

    According to https://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback, the write() callback may be called with an Error before on('error') is invoked. In this case, we should reject our Stream. In the current implementation, we would accept the Stream as healthy and then forward the error to the user, which prevents retries.

I noticed while looking at this code as we are porting it to Python
    @schmidt-sebastian
    schmidt-sebastian committed Jan 24, 2020
    Copy the full SHA
    4405062 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrschmidt/errorhandling

    @schmidt-sebastian
    schmidt-sebastian committed Jan 24, 2020
    Copy the full SHA
    abe6453 View commit details
    Browse the repository at this point in the history