Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't format log message if logging is disable #874

Merged
merged 1 commit into from Jan 13, 2020
Merged

fix: don't format log message if logging is disable #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions dev/src/logger.ts
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ import {validateFunction} from './validate';
let libVersion: string;

/*! The external function used to emit logs. */
let logFunction = (msg: string) => {};
let logFunction: ((msg: string) => void) | undefined = undefined;

/**
* Log function to use for debug output. By default, we don't perform any
Expand All @@ -38,12 +38,14 @@ export function logger(
): void {
requestTag = requestTag || '#####';

const formattedMessage = util.format(logMessage, ...additionalArgs);
const time = new Date().toISOString();
logFunction(
`Firestore (${libVersion}) ${time} ${requestTag} [${methodName}]: ` +
formattedMessage
);
if (logFunction) {
const formattedMessage = util.format(logMessage, ...additionalArgs);
const time = new Date().toISOString();
logFunction(
`Firestore (${libVersion}) ${time} ${requestTag} [${methodName}]: ` +
formattedMessage
);
}
}

/**
Expand Down