Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2.0.0 #621

Closed
wants to merge 4 commits into from
Closed

chore: release 2.0.0 #621

wants to merge 4 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 14, 2019

馃 I have created a release *beep* *boop*

2.0.0 (2019-05-14)

Bug Fixes

Build System

BREAKING CHANGES

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2019
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #621 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   61.54%   61.45%   -0.09%     
==========================================
  Files          21       21              
  Lines        3409     3409              
  Branches      460      460              
==========================================
- Hits         2098     2095       -3     
- Misses       1250     1252       +2     
- Partials       61       62       +1
Impacted Files Coverage 螖
dev/src/watch.ts 96.52% <0%> (-1.16%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4c60e09...a0e8547. Read the comment docs.

@@ -4,6 +4,26 @@

[1]: https://www.npmjs.com/package/@google-cloud/firestore?activeTab=versions

## [2.0.0](https://www.github.com/googleapis/nodejs-firestore/compare/v1.3.0...v2.0.0) (2019-05-14)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we more explicit about dropping Node 6 support? Something like:


**Note:** As of v2.0.0, Firestore requires at least Node v8.10.0.

### Bug Fixes...

I am not 100% that everyone will understand the meaning of the engine field.

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold off on merging since we may want to address some deprecations. Thank you.

@bcoe
Copy link
Contributor Author

bcoe commented May 15, 2019

we will regenerate this once @schmidt-sebastian has landed a couple other breaking changes we'd like to get into 2.x.

@bcoe bcoe closed this May 15, 2019
@bcoe bcoe deleted the release-v2.0.0 branch May 15, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: closed cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants