Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for Query Profiling #1934

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: Support for Query Profiling #1934

wants to merge 17 commits into from

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas requested review from a team as code owners October 26, 2023 21:14
@ehsannas ehsannas self-assigned this Oct 26, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Oct 26, 2023
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Oct 26, 2023
@ehsannas
Copy link
Contributor Author

@MarkDuckworth Please take a look.
Notes:
1- The protos haven't landed in main, so the "base" branch for this PR is query_profiling_base in which I have manually added the protos. And the branch for this pr (query_profiling_impl) builds on top of query_profiling_base.
2- The tests are expected to fail as the requests get rejected by the backend.

MarkDuckworth
MarkDuckworth reviewed Nov 15, 2023
View reviewed changes
types/firestore.d.ts Outdated Show resolved Hide resolved
MarkDuckworth
MarkDuckworth reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. There are some thoughts for your consideration.

types/firestore.d.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Outdated Show resolved Hide resolved
dev/src/convert.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
ehsannas
ehsannas commented Nov 21, 2023
View reviewed changes
dev/src/convert.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Outdated Show resolved Hide resolved
MarkDuckworth
MarkDuckworth approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments for your consideration, but otherwise this looks good.

types/firestore.d.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Show resolved Hide resolved
dev/src/serializer.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Show resolved Hide resolved
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/release/docs-devsite.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 4, 2024
@ehsannas ehsannas changed the base branch from ehsann/query_profiling_base to main January 10, 2024 21:56
MarkDuckworth
MarkDuckworth approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look great.

types/firestore.d.ts Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehsannas @MarkDuckworth