Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lower batch size on BulkWriter retry to stay under throughput limits #1556

Merged
merged 3 commits into from Jul 14, 2021
Merged

fix: lower batch size on BulkWriter retry to stay under throughput limits #1556

merged 3 commits into from Jul 14, 2021

Conversation

thebrianchen
Copy link

Backporting changes from java

@thebrianchen thebrianchen requested review from a team as code owners July 9, 2021 16:32
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jul 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@thebrianchen thebrianchen changed the title chore: fix retry batch fix: fix retry batch Jul 9, 2021
schmidt-sebastian
schmidt-sebastian reviewed Jul 13, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is not very explanatory. We can make this a chore or use a more descriptive title.

@thebrianchen thebrianchen changed the title fix: fix retry batch fix: lower batch size on BulkWriter retry to stay under throughput limits Jul 13, 2021
@thebrianchen thebrianchen merged commit f17a36e into master Jul 14, 2021
@thebrianchen thebrianchen deleted the bc/bulk-back-port branch July 14, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thebrianchen @schmidt-sebastian