fix: recursive delete: backporting changes from Java #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
thebrianchen
changed the title
thebrianchen
force-pushed
the
bc/rc-backport
branch
from
dd4d892
to
ea8782a
Compare
schmidt-sebastian
approved these changes
May 26, 2021
dev/src/recursive-delete.ts
Outdated
| private started = false; | ||
|
|
||
| /** Query limit to use when fetching all descendants. */ | ||
| private maxPendingOps: number; |
There was a problem hiding this comment.
Does this need to be marked "private" (here and below)?
There was a problem hiding this comment.
Thanks for catching, done.
dev/test/recursive-delete.ts
Outdated
| // This deferred completes when the second query is run. | ||
| const secondQueryDeferred = new Deferred<void>(); | ||
|
|
||
| const firstStream = Array.from(Array(maxPendingOps).keys()).map((_, i) => |
There was a problem hiding this comment.
Can you create a helper variable for Array.from(Array(maxPendingOps).keys()) and name it appropriately? It is used twice and not very pretty :)
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [4.12.1](https://www.github.com/googleapis/nodejs-firestore/compare/v4.12.0...v4.12.1) (2021-05-27) ### Bug Fixes * do not load google-gax at client startup ([#1517](https://www.github.com/googleapis/nodejs-firestore/issues/1517)) ([2141b08](https://www.github.com/googleapis/nodejs-firestore/commit/2141b0879cbccb1354f9821edcc917b6aa4ff0ab)) * recursive delete: backporting changes from Java ([#1514](https://www.github.com/googleapis/nodejs-firestore/issues/1514)) ([92ea651](https://www.github.com/googleapis/nodejs-firestore/commit/92ea651adc84ba854ae7cd203af231573f885307)) * return results from getPartitions() in order ([#1521](https://www.github.com/googleapis/nodejs-firestore/issues/1521)) ([c8168a8](https://www.github.com/googleapis/nodejs-firestore/commit/c8168a83a864dd77f88b1743adcd3568671702fe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting some changes from the Java port