Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow logging to be disabled #880

Merged
merged 3 commits into from Jan 14, 2020
Merged

feat: allow logging to be disabled #880

merged 3 commits into from Jan 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Fixes #877

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020 •
edited

Codecov Report

Merging #880 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
+ Coverage    94.9%   94.91%   +<.01%     
==========================================
  Files          25       25              
  Lines       15205    15232      +27     
  Branches     1128     1134       +6     
==========================================
+ Hits        14430    14457      +27     
  Misses        767      767              
  Partials        8        8
Impacted Files Coverage Δ
dev/src/serializer.ts 95.32% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2703f...661380f. Read the comment docs.

thebrianchen
thebrianchen approved these changes Jan 14, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit 36d75f6 into master Jan 14, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/turnofflogging branch January 15, 2020 04:57
@yoshi-automation yoshi-automation mentioned this pull request Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore: unable to turn logging on for a period of time
3 participants
@schmidt-sebastian @thebrianchen @googlebot