Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't format log message if logging is disable #874

Merged
merged 1 commit into from Jan 13, 2020
Merged

fix: don't format log message if logging is disable #874

merged 1 commit into from Jan 13, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Fixes #871

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #874 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #874      +/-   ##
=========================================
+ Coverage    94.9%   94.9%   +<.01%     
=========================================
  Files          25      25              
  Lines       15200   15202       +2     
  Branches     1128    1128              
=========================================
+ Hits        14425   14427       +2     
  Misses        767     767              
  Partials        8       8
Impacted Files Coverage Δ
dev/src/logger.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c2819...5c966d6. Read the comment docs.

thebrianchen
thebrianchen approved these changes Jan 13, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, didn't realize it could eat up that many cycles

@schmidt-sebastian schmidt-sebastian merged commit b7b5fc9 into master Jan 13, 2020
@dmitry-fa dmitry-fa mentioned this pull request Jan 14, 2020
Closed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/logging branch January 15, 2020 04:57
@yoshi-automation yoshi-automation mentioned this pull request Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore client performing logging
3 participants
@schmidt-sebastian @thebrianchen @googlebot