Skip to content

fix: allow running source with ts-node #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

fix: allow running source with ts-node #1074

merged 1 commit into from
May 8, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

ts-node is not able to resolve the FirebaseFirestore namespace. It only exists in our types.

@schmidt-sebastian
fix: allow running source with ts-node
70aca58 
ts-node is not able to resolve the FirebaseFirestore namespace. It only exists in our types.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
thebrianchen
thebrianchen approved these changes May 8, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up! I believe I fixed this when changing the signature to support QueryDocumentSnapshot, but didn't merge it into master.

@schmidt-sebastian schmidt-sebastian merged commit f66a089 into master May 8, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixtypes branch June 24, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @thebrianchen @googlebot