refactor: remove usage of 'self' (#884)

googleapis · Jan 15, 2020 · cd0d758 · cd0d758
1 parent b2740ed
commit cd0d758
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/dev/src/index.ts b/dev/src/index.ts
@@ -898,10 +898,8 @@ export class Firestore {
       request.mask = {fieldPaths};
     }
 
-    const self = this;
-    return self
-      .requestStream('batchGetDocuments', request, requestTag)
-      .then(stream => {
+    return this.requestStream('batchGetDocuments', request, requestTag).then(
+      stream => {
         return new Promise<Array<DocumentSnapshot<T>>>((resolve, reject) => {
           stream
             .on('error', err => {
@@ -924,15 +922,15 @@ export class Firestore {
                     'Received document: %s',
                     response.found.name!
                   );
-                  document = self.snapshot_(response.found, response.readTime!);
+                  document = this.snapshot_(response.found, response.readTime!);
                 } else {
                   logger(
                     'Firestore.getAll_',
                     requestTag,
                     'Document missing: %s',
                     response.missing!
                   );
-                  document = self.snapshot_(
+                  document = this.snapshot_(
                     response.missing!,
                     response.readTime!
                   );
@@ -983,7 +981,8 @@ export class Firestore {
             });
           stream.resume();
         });
-      });
+      }
+    );
   }
 
   /**

diff --git a/dev/src/reference.ts b/dev/src/reference.ts
@@ -1747,14 +1747,12 @@ export class Query<T = DocumentData> {
    * @param {bytes=} transactionId A transaction ID.
    */
   _get(transactionId?: Uint8Array): Promise<QuerySnapshot<T>> {
-    const self = this;
     const docs: Array<QueryDocumentSnapshot<T>> = [];
 
     return new Promise((resolve, reject) => {
       let readTime: Timestamp;
 
-      self
-        ._stream(transactionId)
+      this._stream(transactionId)
         .on('error', err => {
           reject(err);
         })