feat: add support for setting DNS Sec #439
Conversation
product-auto-label
bot
added
the
api: dns
google-cla
bot
added
the
cla: yes
| const [zones] = await dns.getZones(); | ||
| await Promise.all(zones.map(zone => zone.delete({force: true}))); |
There was a problem hiding this comment.
@bcoe this is kind of funny. If two test suites happened to be running at the same time, there's no way this was going to work 馃槅
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 97.81% 97.84% +0.03%
==========================================
Files 6 6
Lines 2332 2365 +33
Branches 63 83 +20
==========================================
+ Hits 2281 2314 +33
Misses 49 49
Partials 2 2
Continue to review full report at Codecov.
|
| const [zones] = await dns.getZones(); | ||
| await Promise.all(zones.map(zone => zone.delete({force: true}))); |
| @@ -55,6 +55,39 @@ export interface CreateZoneRequest { | |||
| dnsName: string; | |||
| description?: string; | |||
| name?: string; | |||
| dnssecConfig?: ManagedZoneDnsSecConfig; | |||
There was a problem hiding this comment.
The API already excepted this field, but we weren't setting it?
There was a problem hiding this comment.
Yeah, there are many fields this thing accepts that we're not currently exposing. For now, this one gets us out of overground jail though.
So @amanda-tarafa this was the easiest way to deal with the overground warnings, and it happens to be kinda nice for customers so 馃し