Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing optional parameter 'dnssec' #32

Closed
busunkim96 opened this issue Dec 2, 2020 · 5 comments
Closed

Missing optional parameter 'dnssec' #32

busunkim96 opened this issue Dec 2, 2020 · 5 comments
Labels
api: dns Issues related to the googleapis/python-dns API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

https://cloud.google.com/dns/docs/dnssec-config#creating
@busunkim96 busunkim96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 2, 2020
@busunkim96 busunkim96 self-assigned this Dec 2, 2020
@product-auto-label product-auto-label bot added the api: dns Issues related to the googleapis/python-dns API. label Dec 2, 2020
@JustinBeckwith
Copy link
Contributor

In a comical backwards series of events, I just brought this forward to fix the overground bug googleapis/nodejs-dns#439

@busunkim96
Copy link
Contributor Author

@JustinBeckwith Was it fairly easy to just add this parameter in the NodeJS library? I'm dDebating whether I should attempt to add this now or wait for REGAPIC.

@JustinBeckwith
Copy link
Contributor

Yeah this was super easy to add

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 22, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 1, 2021
@parthea
Copy link
Contributor

parthea commented Jun 1, 2021

@busunkim96 Please can you take a look?

@JustinBeckwith JustinBeckwith added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 1, 2021
@busunkim96
Copy link
Contributor Author

busunkim96 commented Jun 1, 2021 •
edited

Thanks @JustinBeckwith, I agree this is a feature request. Given DIREGAPIC is imminent, I'm going to continue to punt on this. The last time I looked into this the current client was different enough from the API that adding this wasn't a one line parameter drop in.

One more note - for a client with full coverage of the API, folks can use the discovery client google-api-python-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: dns Issues related to the googleapis/python-dns API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JustinBeckwith @parthea @meredithslota @busunkim96 @yoshi-automation