fix: correct Long types import

[SimenB]

Fixes #345

Ref #352

[SimenB]

ergh no, the generator removes the manual edit I made 😅 Does need the dependency in package.json, though

[JustinBeckwith]

Thank you so much for submitting a fix! And sorry for the 🤦‍♂️ You were super close.

[JustinBeckwith]

Yarrr, nice find and sorry for the mixup. What you really wanna do here is update this line in package.json:

"proto:datastore": "mkdir -p proto && pbjs -t static-module -w commonjs -p node_modules/google-proto-files google/datastore/v1/datastore.proto | pbts -i long -o proto/datastore.d.ts -",

Make that:

"proto:datastore": "mkdir -p proto && pbjs -t static-module -w commonjs -p node_modules/google-proto-files google/datastore/v1/datastore.proto | pbts -i Long -o proto/datastore.d.ts -",

That way the fix doesn't get roughed up by the generator.

[SimenB]

Then it's import Long from 'Long' which I guess will go boom on linux?

[JustinBeckwith]

Nah, it'll probably be fine

[mgabeler-lee-6rs]

This very much will blow up on Linux -- import filenames are case sensitive there. Applying the suggestion results in:

> @google-cloud/datastore@3.1.2 compile /home/mgl/3psrc/nodejs-datastore
> tsc -p . && cp -r src/v1 build/src && cp -r proto* build && cp test/*.js build/test

proto/datastore.d.ts:2:23 - error TS2307: Cannot find module 'Long'.

2 import * as Long from "Long";
                        ~~~~~~


Found 2 errors.

[stephenplusplus]

Is this what we want? protobufjs/protobuf.js#1166

[JustinBeckwith]

Yes lol. That would fix all the things.

[codecov]

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files           5        5           
  Lines         617      617           
  Branches      145      145           
=======================================
  Hits          605      605           
  Partials       12       12

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bc787...9230198. Read the comment docs.

[callmehiphop]

@JustinBeckwith in some of the other clients we are just editing the generated file until a better solution presents itself. Assuming we're cool doing that here as well, I think this PR is good to go unless you have any objections

[JustinBeckwith]

SGTM. Let's just be careful about not blasting these away :)

[callmehiphop]

@JustinBeckwith I see you became a contributor to Protobuf.js 😮 any chance we'll see a release soon with the Long fix?

[callmehiphop]

Going to merge this, but until the needed patch for protobufjs is released we should be mindful not to overwrite this change by re-generating types.